[Parse] Drop Swift3 support for conditional compilation condition #17789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@rintaro Thanks for working on this! Can you merge the test changes separately first? |
In Swift3: * `#if A is B` were warning * `#if A(foo:)` were warning * `#if A || B && C` has different meaning from Swift4+ and was diagnosed with migration support fix-it.
rintaro
force-pushed
the
parse-ifconfig-drop3
branch
from
e1ade49 to
2946597
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift3:
#if A is Bwas warning#if A(foo:)was warning#if A || B && Chas different meaning from Swift4+ and was diagnosed with migration support fix-it.