Skip to content

[stdlib] Remove inlineable annotation from transparent functions #17800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2018
Merged

[stdlib] Remove inlineable annotation from transparent functions #17800

merged 2 commits into from
Jul 7, 2018

Conversation

airspeedswift
Copy link
Member

If a function is @_transparent it shouldn't need to be @inlinable too.

Some of these uses of @_transparent maybe be better marked as @inlinable instead but that is for a later audit.

@airspeedswift airspeedswift requested a review from slavapestov July 6, 2018 20:30
@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Jul 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - c263059

@airspeedswift
Copy link
Member Author

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 6, 2018

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

Regressions found (see below)

Debug

debug brief

Regressed (1)
name old new delta delta_pct
time.swift-driver.wall 71.5s 77.9s 6.3s 8.85% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 36,055,500 36,055,482 -18 -0.0%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 45,372 45,372 0 0.0%
AST.NumLoadedModules 6,072 6,072 0 0.0%
AST.NumTotalClangImportedEntities 132,018 132,018 0 0.0%
AST.NumUsedConformances 8,754 8,754 0 0.0%
IRModule.NumIRBasicBlocks 127,649 127,649 0 0.0%
IRModule.NumIRFunctions 75,824 75,824 0 0.0%
IRModule.NumIRGlobals 68,976 68,976 0 0.0%
IRModule.NumIRInsts 1,424,665 1,424,665 0 0.0%
IRModule.NumIRValueSymbols 129,678 129,678 0 0.0%
LLVM.NumLLVMBytesOutput 36,055,500 36,055,482 -18 -0.0%
SILModule.NumSILGenFunctions 42,873 42,873 0 0.0%
SILModule.NumSILOptFunctions 47,245 47,245 0 0.0%
Sema.NumConformancesDeserialized 185,258 185,258 0 0.0%
Sema.NumConstraintScopes 869,055 869,055 0 0.0%
Sema.NumDeclsDeserialized 1,097,861 1,097,861 0 0.0%
Sema.NumDeclsValidated 95,528 95,528 0 0.0%
Sema.NumFunctionsTypechecked 29,337 29,337 0 0.0%
Sema.NumGenericSignatureBuilders 42,865 42,865 0 0.0%
Sema.NumLazyGenericEnvironments 203,887 203,887 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 22,559 22,559 0 0.0%
Sema.NumLazyIterableDeclContexts 167,190 167,190 0 0.0%
Sema.NumTypesDeserialized 1,173,536 1,173,536 0 0.0%
Sema.NumTypesValidated 83,276 83,276 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 26,786,716 26,786,716 0 0.0%
time.swift-driver.wall 158.6s 158.7s 80.3ms 0.05%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 8,868 8,868 0 0.0%
AST.NumLoadedModules 408 408 0 0.0%
AST.NumTotalClangImportedEntities 25,973 25,973 0 0.0%
AST.NumUsedConformances 8,760 8,760 0 0.0%
IRModule.NumIRBasicBlocks 147,893 147,893 0 0.0%
IRModule.NumIRFunctions 57,374 57,374 0 0.0%
IRModule.NumIRGlobals 55,392 55,392 0 0.0%
IRModule.NumIRInsts 1,211,274 1,211,274 0 0.0%
IRModule.NumIRValueSymbols 103,411 103,411 0 0.0%
LLVM.NumLLVMBytesOutput 26,786,716 26,786,716 0 0.0%
SILModule.NumSILGenFunctions 22,236 22,236 0 0.0%
SILModule.NumSILOptFunctions 35,700 35,700 0 0.0%
Sema.NumConformancesDeserialized 84,438 84,438 0 0.0%
Sema.NumConstraintScopes 796,060 796,060 0 0.0%
Sema.NumDeclsDeserialized 204,565 204,565 0 0.0%
Sema.NumDeclsValidated 59,866 59,866 0 0.0%
Sema.NumFunctionsTypechecked 10,719 10,719 0 0.0%
Sema.NumGenericSignatureBuilders 9,578 9,578 0 0.0%
Sema.NumLazyGenericEnvironments 32,352 32,352 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 4,601 4,601 0 0.0%
Sema.NumLazyIterableDeclContexts 20,732 20,732 0 0.0%
Sema.NumTypesDeserialized 266,903 266,903 0 0.0%
Sema.NumTypesValidated 32,554 32,554 0 0.0%

@swift-ci
Copy link
Contributor

swift-ci commented Jul 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - c263059

@slavapestov
Copy link
Contributor

I don’t understand why there was a regression. I would expect the change to be NFC

@airspeedswift
Copy link
Member Author

It’s wall time, none of the counters changed, so it could be a glitch.

@swift-ci please smoke test compiler performance

@airspeedswift
Copy link
Member Author

@swift-ci please test Linux platform

@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Jul 7, 2018

Build failed
Swift Test Linux Platform
Git Sha - c263059

@swift-ci
Copy link
Contributor

swift-ci commented Jul 7, 2018

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 36,237,690 36,237,664 -26 -0.0%
time.swift-driver.wall 62.9s 62.8s -151.0ms -0.24%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 38,786 38,786 0 0.0%
AST.NumLoadedModules 5,023 5,023 0 0.0%
AST.NumTotalClangImportedEntities 115,390 115,390 0 0.0%
AST.NumUsedConformances 8,754 8,754 0 0.0%
IRModule.NumIRBasicBlocks 127,857 127,857 0 0.0%
IRModule.NumIRFunctions 76,032 76,032 0 0.0%
IRModule.NumIRGlobals 69,600 69,600 0 0.0%
IRModule.NumIRInsts 1,428,019 1,428,019 0 0.0%
IRModule.NumIRValueSymbols 130,302 130,302 0 0.0%
LLVM.NumLLVMBytesOutput 36,237,690 36,237,664 -26 -0.0%
SILModule.NumSILGenFunctions 44,443 44,443 0 0.0%
SILModule.NumSILOptFunctions 47,463 47,463 0 0.0%
Sema.NumConformancesDeserialized 166,093 166,093 0 0.0%
Sema.NumConstraintScopes 866,350 866,350 0 0.0%
Sema.NumDeclsDeserialized 974,219 974,219 0 0.0%
Sema.NumDeclsValidated 89,446 89,446 0 0.0%
Sema.NumFunctionsTypechecked 25,574 25,574 0 0.0%
Sema.NumGenericSignatureBuilders 38,079 38,079 0 0.0%
Sema.NumLazyGenericEnvironments 179,343 179,343 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 20,487 20,487 0 0.0%
Sema.NumLazyIterableDeclContexts 145,392 145,392 0 0.0%
Sema.NumTypesDeserialized 1,041,041 1,041,041 0 0.0%
Sema.NumTypesValidated 76,744 76,744 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 26,786,716 26,786,716 0 0.0%
time.swift-driver.wall 141.3s 141.4s 69.4ms 0.05%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 8,868 8,868 0 0.0%
AST.NumLoadedModules 408 408 0 0.0%
AST.NumTotalClangImportedEntities 25,973 25,973 0 0.0%
AST.NumUsedConformances 8,760 8,760 0 0.0%
IRModule.NumIRBasicBlocks 147,893 147,893 0 0.0%
IRModule.NumIRFunctions 57,374 57,374 0 0.0%
IRModule.NumIRGlobals 55,392 55,392 0 0.0%
IRModule.NumIRInsts 1,211,274 1,211,274 0 0.0%
IRModule.NumIRValueSymbols 103,411 103,411 0 0.0%
LLVM.NumLLVMBytesOutput 26,786,716 26,786,716 0 0.0%
SILModule.NumSILGenFunctions 22,236 22,236 0 0.0%
SILModule.NumSILOptFunctions 35,700 35,700 0 0.0%
Sema.NumConformancesDeserialized 84,438 84,438 0 0.0%
Sema.NumConstraintScopes 796,060 796,060 0 0.0%
Sema.NumDeclsDeserialized 204,565 204,565 0 0.0%
Sema.NumDeclsValidated 59,866 59,866 0 0.0%
Sema.NumFunctionsTypechecked 10,719 10,719 0 0.0%
Sema.NumGenericSignatureBuilders 9,578 9,578 0 0.0%
Sema.NumLazyGenericEnvironments 32,352 32,352 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 4,601 4,601 0 0.0%
Sema.NumLazyIterableDeclContexts 20,732 20,732 0 0.0%
Sema.NumTypesDeserialized 266,903 266,903 0 0.0%
Sema.NumTypesValidated 32,554 32,554 0 0.0%

@airspeedswift
Copy link
Member Author

Yeah, glitch.

@airspeedswift
Copy link
Member Author

@swift-ci please test Linux platform

@airspeedswift airspeedswift merged commit a6952de into swiftlang:master Jul 7, 2018
@airspeedswift airspeedswift deleted the transparent-inlinable branch July 7, 2018 15:47
@airspeedswift airspeedswift mentioned this pull request Jul 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airspeedswift @swift-ci @slavapestov