[SILGen] Output a different message for failed IUO force-unwraps #17826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Modifies SILGen and the `Swift._diagnoseUnexpectedNilOptional` call to print a slightly different message for force unwraps which were implicitly inserted by the compiler for IUOs. The message is chosen based on the presence of certain flags in the `ForceValueExpr`, not on the type of the value being unwrapped.
@jckarter pointed out that force unwraps emitted in thunks are always for IUOs and should use the implicit unwrap message.
|
Rebased on master. @swift-ci please smoke test |
|
@jckarter Is there anything I should do before this can be merged? |
jckarter
approved these changes
Jul 20, 2018
|
Looks good! |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies SILGen and the
Swift._diagnoseUnexpectedNilOptionalcall to print a slightly different message for force unwraps which were implicitly inserted by the compiler for IUOs. That is, these two lines will produce different messages:The message is chosen based on the presence of certain flags in the
ForceValueExpr, not on the type of the value being unwrapped, somyIUO!.foo()would print the first message, not the second.Resolves SR-8170.