Skip to content

Install llbuild swift bindings #17829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

hartbit
Copy link
Contributor

@hartbit hartbit commented Jul 8, 2018

This PR installs the llbuild Swift bindings in the toolchain so they can be dynamically linked from SwiftPM.

@hartbit
Copy link
Contributor Author

hartbit commented Jul 8, 2018

Please build with following pull request:
swiftlang/swift-llbuild#341

@swift-ci Please Build Toolchain macOS Platform

@aciidgh
Copy link
Contributor

aciidgh commented Jul 8, 2018

Please build with following pull request:
swiftlang/swift-llbuild#341

@swift-ci Please Build Toolchain Linux Platform

@aciidgh
Copy link
Contributor

aciidgh commented Jul 8, 2018

Please build with following pull request:
swiftlang/swift-llbuild#341

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 8, 2018

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 335290e

Install command
tar zxf swift-PR-17829-36-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

swift-ci commented Jul 8, 2018

macOS Toolchain
Download Toolchain
Git Sha - 335290e

Install command
tar -zxf swift-PR-17829-46-osx.tar.gz --directory ~/

@gottesmm
Copy link
Contributor

gottesmm commented Jul 9, 2018

Can you guys add a test that this is installed correctly in the integration repo: https://github.com/apple/swift-integration-tests.

@aciidgh
Copy link
Contributor

aciidgh commented Jul 9, 2018

@gottesmm do you think such a test will be very valuable? SwiftPM intends to link with this library and will fail to run without it. If that happens, it will be caught by the existing swiftpm tests in the integration repo.

@gottesmm
Copy link
Contributor

gottesmm commented Jul 9, 2018

@aciidb0mb3r thats good enough for me. I just wanted to make sure that there was /something/.

@hartbit
Copy link
Contributor Author

hartbit commented Jul 9, 2018

Please build with following pull request:
swiftlang/swift-llbuild#341

@swift-ci Please Build Toolchain Linux Platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2018

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 335290e

Install command
tar zxf swift-PR-17829-37-ubuntu16.04.tar.gz
More info

@aciidgh
Copy link
Contributor

aciidgh commented Jul 9, 2018

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants