Skip to content

[stdlib] Some stubs and trivial refactorings; NFC #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

milseman
Copy link
Member

@milseman milseman commented Jul 9, 2018

No description provided.

milseman added 2 commits July 9, 2018 10:45
Refactor out the implementation of index(_:offsetBy) and others from
BidirectionalCollection so that conformers can choose to invoke the
default implementations explicitly. This is very useful for types such
as String which have common fast-paths to check before falling back on
the general approach.
Add ICU shims for creating UTexts and performing grapheme breaking
using UTexts. This will allow us to explore multi-encoding grapheme
support throughout string.
@milseman
Copy link
Member Author

milseman commented Jul 9, 2018

@swift-ci please test and merge

@milseman
Copy link
Member Author

milseman commented Jul 9, 2018

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - 5358401

@milseman
Copy link
Member Author

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5358401

@milseman
Copy link
Member Author

(that Linux failure seems to be happening on other PRs yesterday)

@swift-ci please test Linux platform

@milseman milseman merged commit 88fb124 into swiftlang:master Jul 10, 2018
@milseman milseman deleted the nfc branch July 10, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants