Skip to content

[SpaceEngine] NFC: Switch to != instead of compare on Head iden… #17842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 9, 2018

…tifiers

Since Head comparison only checks for equality, all of such
checks could be switched from compare to != operator.

…tifiers

Since `Head` comparison only checks for equality, all of such
checks could be switched from `compare` to `!=` operator.
@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - c13a10e

@xedin
Copy link
Contributor Author

xedin commented Jul 9, 2018

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - c13a10e

@xedin
Copy link
Contributor Author

xedin commented Jul 10, 2018

@swift-ci please smoke test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Jul 10, 2018

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c13a10e

@xedin
Copy link
Contributor Author

xedin commented Jul 10, 2018

some unrelated lldb failures, lets try again...

@xedin
Copy link
Contributor Author

xedin commented Jul 10, 2018

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c13a10e

@xedin
Copy link
Contributor Author

xedin commented Jul 10, 2018

@swift-ci please smoke test Linux platform

@dingobye
Copy link
Contributor

I am experiencing such lldb failure as well in #17545 ...

@xedin
Copy link
Contributor Author

xedin commented Jul 11, 2018

@swift-ci please test Linux platform

@xedin xedin merged commit 131b860 into swiftlang:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants