Protocol superclass constraints part 4 #17851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
protocol-superclass-part-4
branch
from
4ef160f to
d70419e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@aciidb0mb3r Any ideas? |
|
@swift-ci Please smoke test Linux |
These will never work properly because of phase ordering issues with the current declaration checker design. Since we can always express the same thing with the protocol inheritance clause instead, just diagnose this as an error instead of trying to hack around it. Fixes <rdar://problem/38077232>, <https://bugs.swift.org/browse/SR-5581>.
slavapestov
force-pushed
the
protocol-superclass-part-4
branch
from
d70419e to
eeb5c95
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test source compatibility |
|
@slavapestov sorry about that, I’ll fix them first thing in the morning. |
|
Disabled the tests in swiftlang/swift-integration-tests@a39ef35 |
|
@swift-ci Please smoke test Linux |
|
The source compat suite is broken right now. I'll keep an eye on the bots after merging this. |
This was referenced Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/38077232 / https://bugs.swift.org/browse/SR-5581, and rdar://problem/34812895 / https://bugs.swift.org/browse/SR-6000.