[NFC] Drop PerformJobsState as a friend class #17864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the coupling between PerformJobsState and Compilation indirect.
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Jul 10, 2018
|
⛵️ |
|
I was surprised that you asked for my review and then merged so quickly before I could get to it. However, it’s a very innocuous change! I like the decoupling. |
|
@davidungar Sorry about that. I usually tag all the stakeholders I can think of as a way to cast a wide net rather than gather a list of gates for smaller patches like these. Thank you for the vote of confidence! |
|
@CodaFi Thanks for responding. In the future if you put me down as a reviewer, if you want me to assume that you specifically want my review, please let me know somehow. Otherwise I'll assume that, as with this PR, you are casting that wide net. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the coupling between PerformJobsState and Compilation indirect and expose some convenient accessors in the process.