[Type checker] Add a request for overridden declarations #17878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of getAsClassOrClassExtensionContext() obviates the need for a specific isTypeContext() check. NFC.
…ookup. Make the TypeChecker’s name-lookup routines static, so they don’t depend on the TypeCheck instance… except for one pesky place where we jump back into protocol conformance checking. This is part of teasing apart the type checker.
…nyRequest The default move constructor and move assignment operator of AnyRequest would leave the source object in an odd state that’s destructible but does not maintain the invariant that all “normal” states store a real instance. This state breaks DenseMap, which assumes that a moved-from object is still washable.
Don’t ask to compute overridden declarations that haven’t already been computed.
Introduce a new request kind to capture the computation of the set of overridden declarations of a given declaration, eliminating the stateful “setOverriddenDecls()” calls from the type checker.
The overridden declarations of accessors are computed; they don’t need to be set explicitly.
DougGregor
force-pushed
the
overridden-decls-request
branch
from
71de635 to
7f70cbf
Compare
|
This can't build the Foundation overlay due to a cycle between override checking and @objc checking. I may need to make both requests before I can land either one :( |
|
This keeps growing. New PR up at #17976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.