[4.2] [codecomplete] Add completion of if after else
#17883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlangmuir
commented
Jul 11, 2018
benlangmuir
commented
- Explanation: At some point we stopped completing keywords after else in an if statement. The fix is to add back the completion of if, which is the only valid continuation other than a brace.
- Scope: Affects code-completion for if-else statements.
- Issue: rdar://37467474
- Risk: Low; just adds an additional code-completion callback from the parser that adds the keyword completion.
- Testing: Regression tests added.
- Reviewed by: @nkcsgexi
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
At some point we stopped completing keywords after `else` in an if statement. Bring back the completion of `if`, which is the only valid continuation other than a brace. rdar://37467474
benlangmuir
force-pushed
the
cc-if-else-if-42
branch
from
b2dc923 to
dee5110
Compare
|
Change: on swift-4.2 there was one extra call to |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.