SILOptimizer: Remove 'unique ID' from FSO mangling #17892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@rajbarik Please take a look |
|
Build failed |
|
@swift-ci Please smoke test Linux |
|
Linux test failed at the very end — this is an lldb problem, not me: [TestSwiftTupleTypes.py FAILED] |
|
@slavapestov @atrick I am running into naming troubles with this kind of naming that does not include IDs. For my existential2generic transformation, I get an assertion failure [with name existing] when building swiftpm [ https://github.com//pull/19820]. Does it make sense to revert this one back? Are there other work arounds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.