[4.2] [Driver] Always link compiler_rt on Darwin (when available) #17896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Driver] Always link compiler_rt on Darwin (when available) rdar://problem/41911599 (cherry picked from commit b02d554)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Various C and Objective-C features are implemented using functions in the compiler_rt project, and Swift can end up using some of those features simply by importing inlinable C code. This includes Objective-C's
@availablefeature (the equivalent of Swift's#available). Clang always links the usualclang_rtlibrary to supply these features, so Swift should too.Scope: Affects the package manager and users manually invoking swiftc to build executables and libraries. (Xcode uses Clang to link.)
Issue: rdar://problem/41911599
Risk: Low. The change is straightforward and the effects should be safe, given that this is what Clang and Xcode already do.
Testing: Added compiler regression tests.
Reviewed by: @davidungar