[4.2][SpaceEngine] Improve total search space size estimation #17898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
changed the title
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Build failed |
In some situations it is possible to determine that a particular associated value is completely covered by a given `switch` statement before running main checker algorithm, so let's not include sizes of such cases into "total" search space size estimate. Resolves: rdar://problem/40400251 (cherry picked from commit 2b78e16)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In some situations it is possible to determine that a particular
associated value is completely covered by a given
switchstatementbefore running main checker algorithm, so let's not include sizes
of such cases into "total" search space size estimate.
Issue: rdar://problem/40400251
Scope: Affects only preliminary total space size check done by space engine.
Risk: Low.
Testing: Added compiler regression tests.
Reviewed by: @jrose-apple and @CodaFi
Resolves: rdar://problem/40400251
(cherry picked from commit 2b78e16)