[4.2] ASTContext: Recompute the insert position in getSpecializedConformance after the SpecializedProtocolConformance constructor #17916
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance after the SpecializedProtocolConformance constructor The constructor can modify the SpecializedConformances FoldingSet so that the insertPos is no longer valid. It calls computeConditionalRequirements which calls Type::subst which recursively can call getSpecializedConformance again. Therefore, we need to recompute the insertPos after calling the constructor. This bug manifest itself either as memory error with libgmalloc or as spurious errors later on. * Explanation: Memory errors causing spurious failure later in the compiler on our CI tests * Scope: Memory errors are bad. This bug dates back to when conditional conformance were added sometime during 2017. * Risk: Low. A call to recompute the insertion point (a map lookup) is added. *Testing: Existing Swift CI test caught this rdar://42082352
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor can modify the SpecializedConformances FoldingSet so that the
insertPos is no longer valid. It calls computeConditionalRequirements which
calls Type::subst which recursively can call getSpecializedConformance again.
Therefore, we need to recompute the insertPos after calling the
constructor.
This bug manifest itself either as memory error with libgmalloc or as
spurious errors later on.
Explanation: Memory errors causing spurious failure later in the
compiler on our CI tests
Scope: Memory errors are bad. This bug dates back to when conditional
conformance were added sometime during 2017.
Risk: Low. A call to recompute the insertion point (a map lookup) is
added.
*Testing: Existing Swift CI test caught this
rdar://42082352