Skip to content

[Driver] Diagnose -emit-objc-header With Pre-Typechecking Actions #17937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2018
Merged

[Driver] Diagnose -emit-objc-header With Pre-Typechecking Actions #17937

merged 1 commit into from
Jul 13, 2018

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 13, 2018 •
edited
Loading

Depends on #17645. See the last commit.

@CodaFi CodaFi requested a review from jrose-apple July 13, 2018 18:29
jrose-apple
jrose-apple approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, contingent on the other PR landing first.

@CodaFi
-parse and -resolve-imports cannot emit ObjC headers
2ee7e7c 
At least -typecheck is required to be able to emit headers.
@CodaFi CodaFi force-pushed the heading-for-disaster branch from 7e536d9 to 2ee7e7c Compare July 13, 2018 21:57
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 13, 2018

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 9c6ab5b into swiftlang:master Jul 13, 2018
@CodaFi CodaFi deleted the heading-for-disaster branch July 13, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @jrose-apple @swift-ci