[4.2][Diagnostics] Transfer previously resolved types directly from expressions #17953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions While trying to diagnose the problem with previously type-checked sub-expression, use its type-checked variant as a source of type information, instead of transferring from its original constraint system, because if expression was type-checked successfully it would have all of the required information in AST, and that doesn't rely on associated constraint system being present. Resolves: rdar://problem/42056741 (cherry picked from commit d324969)
(cherry picked from commit 11e1d13)
(cherry picked from commit 939f6d4)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
There are no failures, just multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: While trying to diagnose the problem with previously type-checked
sub-expression, use its type-checked variant as a source of type
information, instead of transferring from its original constraint system,
because if expression was type-checked successfully it would
have all of the required information in AST, and that doesn't
rely on associated constraint system being present.
Issue: rdar://problem/42056741
Scope: Diagnostics, in subset of cases when failure detector tries to re-typecheck the same expression multiple times.
Risk: Very low, only affects diagnostics in small subset of recursive cases.
Testing: Added compiler regression tests.
Reviewed by: @rudkx
Resolves: rdar://problem/42056741