Canonicalize swift header files headers and footers #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,5 +57,5 @@ demangleTypeAsString(StringRef MangledTypeName, | |||
| } // end namespace demangle_wrappers | |||
| } // end namespace swift | |||
|
|
|||
| #endif // LLVM_SWIFT_BASIC_DEMANGLE_WRAPPERS_H | |||
| #endif // SWIFT_BASIC_DEMANGLE_WRAPPERS_H | |||
There was a problem hiding this comment.
I am not sure if you need a '_' in between Demangle and wrappers. I would look in swift/llvm to see what people do. IIRC they don't do that.
There was a problem hiding this comment.
Fixed across all files.
|
@swift-ci please test |
- Added missing ifdef guard in PointerIntEnum header - Consistent naming convention for ifdef guards - Consistent 'end namespace swift' - Consistent single EOL at end of header files
danra
force-pushed
the
swift_basic_sanitize
branch
from
1506ee8 to
29d76f3
Compare
danra
changed the title
|
@tkremenek Could you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.