[Parser] Support "<" unary operator in #if swift() and #if compiler() expressions #17960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just lift the restriction on comparison operators altogether? |
|
We don't want to support |
jrose-apple
added
the
swift evolution pending discussion
jrose-apple
reviewed
Jul 16, 2018
danielmartin
force-pushed
the
new-unary-operator-ifconfig
branch
from
912a2e1 to
5823273
Compare
rintaro
reviewed
Jul 23, 2018
Until now, only ">=" was supported in #if swift() expressions, for example: ```#if swift(>=2.1) ```#endif This means that if we want to evaluate code only when the language version is less than a particular version we need to do the following: ```#if !swift(>=2.1) ```#endif An alernative to make this more readable (the "!" can be easily missed in a code review) is to introduce another supported unary operator, "<". The previous example could be rewritten like this: ```#if swift(<2.1) ```#endif This commit adds support for that unary operator, along with some tests.
danielmartin
force-pushed
the
new-unary-operator-ifconfig
branch
from
5823273 to
e66095b
Compare
tkremenek
requested changes
Aug 22, 2018
|
SE-0224 has been approved, so this is clear to land once this PR is approved. |
danielmartin
changed the title
|
@tkremenek, I think this is waiting on you. @swift-ci Please test |
|
Re-running CI against latest master. @swift-ci test |
tkremenek
approved these changes
Sep 25, 2018
AnthonyLatsis
removed
the
swift evolution pending discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift-evolution proposal: swiftlang/swift-evolution#877
Resolves #49401.
Until now, only ">=" was supported in #if swift() expressions, for example:
This means that if we want to evaluate code only when the language version is
less than a particular version we need to do the following:
An alternative to make this more readable (the "!" can be easily missed in a code
review) is to introduce another supported unary operator, "<". The previous
example could be rewritten like this:
This commit adds support for that unary operator, along with some tests.