Change "enum element" to "enum case" in diagnostics #17964
Conversation
| @@ -117,7 +117,7 @@ ERROR(could_not_use_type_member_on_instance,none, | |||
| "static member %1 cannot be used on instance of type %0", | |||
| (Type, DeclName)) | |||
| ERROR(could_not_use_enum_element_on_instance,none, | |||
| "enum element %0 cannot be referenced as an instance member", | |||
| "enum case %0 cannot be used as an instance member", | |||
There was a problem hiding this comment.
I also changed referenced to used here. That seems both clearer and more consistent with other diagnostics.
There was a problem hiding this comment.
This disgnostic should be specialized for implicit self so we can offer something more specific than this. Especially in the common “switch-case is missing a leading dot” examples.
Not something to worry about here, but definitely nice to have in a follow-up.
|
Also, the documentation clearly refers to these as cases and never uses the term elements:
|
|
Goodbye C++isms, hello Swift ⛵️ @swift-ci please smoke test and merge |
From the perspective of the compiler implementation, they're elements. But users will think of these as cases—and many diagnostics already refer to these as enum cases.
mdiep
force-pushed
the
enum-case-not-enum-element
branch
from
5d9bd74 to
3559274
Compare
|
Somehow I missed a test the first time around. 🙈 Updated. |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
From the perspective of the compiler implementation, they're elements. But users will think of these as cases—and many diagnostics already refer to these as enum cases.