Skip to content

[test] Update String tests for older iOS versions #17979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

milseman
Copy link
Member

@milseman milseman commented Jul 16, 2018

4.2 cherry-pick of #17945


Explanation: Adds availability guard for iOS-tests which require a newer OS version.

Scope: Only affects testing on older OSes

Issue: rdar://problem/41763351

Risk: Low, only affects testing

Testing: Regular testing

Reviewer: @clackary

@milseman
Copy link
Member Author

@swift-ci please test

@milseman milseman requested a review from clackary July 16, 2018 18:50
@milseman
Copy link
Member Author

@swift-ci please nominate
Explanation: Adds availability guard for iOS-tests which require a newer OS version.
Scope: Only affects testing on older OSes
Radar/SR Issue: rdar://problem/41763351
Risk: Low, only affects testing
Testing: Regular testing
Reviewer: Clack Cole (@clackary)

Copy link

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@najacque najacque merged commit 5156b7c into swiftlang:swift-4.2-branch Jul 18, 2018
@milseman milseman deleted the 4_2_nfc branch July 18, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants