[TypeChecker] Disable expression diagnostics for code completion #17980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es flags Instead of mixing flags between type-checker and constraint solver, let's move the ones which are useful in constraint system there. Doing so allows for `solveForExpression` to be moved from `TypeChecker` to `ConstraintSystem` which consolidates solver logic. It also allows to set these flags as part of constraint generation/solving, which is sometimes important.
Any produced diagnostics are suppressed anyway by a special diagnostic engine attached to the new type-checker, so there no point of doing any of that work. Resolves: rdar://problem/22996887
rudkx
approved these changes
Jul 16, 2018
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
/cc @nathawes as FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any produced diagnostics are suppressed anyway by a special
diagnostic engine attached to the new type-checker, so there
no point of doing any of that work.
Resolves: rdar://problem/22996887