Change the signature for DispatchData.enumerateBytes() to match that … #17982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci: please smoke test |
|
The code looks good. I wonder if it's worth adding an explicit test that runs in 4.2 mode, so that you can check that the new signature is working too. |
jrose-apple
approved these changes
Jul 17, 2018
| } | ||
| nextIndex = offset + ptr.count | ||
| }) | ||
| #endif |
There was a problem hiding this comment.
I suggest a trailing closure test that's expected to work in both language modes, too.
There was a problem hiding this comment.
Added that test and squashed commits.
…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version. rdar://problem/40775762
ktopley-apple
force-pushed
the
ktopley-dispatch-rdar40775762
branch
from
4d73bb6 to
7b0991f
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test |
|
Build failed |
|
Note for next time: the regular tests include the smoke tests, so you don't actually have to run both. |
mwwa
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version.
rdar://problem/40775762
Adds overload DispatchData.enumerateBytes(_:) to match the signature used in Data and make it available as of Swift 4.2. Also obsoletes the existing version.
Resolves SR-7868.