Handle builtin FP types in SILBuilder::appendOperandTypeName #17988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following builder method doesn't handle floating point operands yet.
```cpp
BuiltinInst *createBuiltinBinaryFunction(SILLocation Loc, StringRef Name,
SILType OpdTy, SILType ResultTy,
ArrayRef<SILValue> Args)
```
This patch adds support for calling this method with floating point operands.
```cpp
SILValue x = ...; // $Builtin.FPIEEE32
B.createBuiltinBinaryFunction(loc, "fmul", x->getType(), x->getType(), { x, x })
```
Corresponding SIL:
```
%0 = builtin "fmul_FPIEEE32"(%x : $Builtin.FPIEEE32, %x : $Builtin.FPIEEE32) : $Builtin.FPIEEE32
```
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
shajrawi
approved these changes
Jul 17, 2018
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jul 23, 2018
Handle builtin FP types in SILBuilder::appendOperandTypeName (cherry picked from commit 1609523)
rxwei
added a commit
that referenced
this pull request
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following builder method doesn't handle floating point operands yet.
BuiltinInst *createBuiltinBinaryFunction(SILLocation Loc, StringRef Name, SILType OpdTy, SILType ResultTy, ArrayRef<SILValue> Args)This patch adds support for calling this method with floating point operands.
Corresponding SIL: