[4.2][stdlib] Update default generator to SystemRandomNumberGenerator #17990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
stephentyrone
approved these changes
Jul 16, 2018
Azoy
approved these changes
Jul 16, 2018
lorentey
approved these changes
Jul 17, 2018
| @@ -32,7 +32,7 @@ import SwiftShims | |||
| /// } | |||
| /// | |||
| /// static func random() -> Weekday { | |||
| /// return Weekday.randomWeekday(using: &Random.default) | |||
| /// return Weekday.random(using: &Random.default) | |||
There was a problem hiding this comment.
This example should be updated to reflect the new name & usage.
|
Thanks all, I'll fix up the docs in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this forum post as an amendment to SE-0202.
This isn't quite a cherry-pick of #17989 since they have diverged a little. I think there are also some other changes we need to pull over from master, looking at the history.