-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Version-guard some emoji tests. #17992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
CC @allevato |
Build failed |
Gate some emoji tests on a new enough iOS version.
Build failed |
Should we gate the properties themselves with availability annotations instead of just the tests? It really feels like bundling ICU with stdlib (as was discussed in SR-6076) is the only way to make sure we can safely roll things like this out on all platforms 😕 |
The properties are available, just the answers to queries can change with the version of Unicode. This is no different than say, Separately, yes, bundling a version of ICU would help Linux. It wouldn't affect this change, as Darwin should use the system's ICU. |
@swift-ci please test and merge |
Ok, that's fair (the fact that we already have that issue with The fact that some of these properties are still unreliable depending on OS version still makes me a bit uncomfortable though, since I don't believe there's any obvious way for a user to map their platform/OS version to the version of Unicode that the system supports. One thing that came up during the proposal review was adding an API to the |
Definintely! |
@swift-ci please test and merge |
Gate some emoji tests on a new enough iOS version.
rdar://problem/42139928