Sema: Fix availability of inherited designated initializers, part 2 [4.2] #18037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to explicitly handle nested types here. Fixes the (re-opened) <rdar://problem/40853731>, <https://bugs.swift.org/browse/SR-7881>.
|
@swift-ci Please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When a class inherits designated initializers from the superclass, we synthesize them. The superclass initializer might be less available than the superclass itself, so we have to inherit availability. We need to intersect this availability with all parent scopes of the subclass, to avoid a "declaration cannot be more available than its surrounding scope" error attached to an unknown source location.
Risk: Low, this adds the outer scope walk to the existing fix.
Tested: New test added.
Radar: rdar://problem/40853731
Reviewed by: @jrose-apple