[4.2] SILGen: Cope with overloads when emitting artificial main for @UIApplicationMain. #18056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icationMain. The overlay may add overloads for UIApplicationMain for various reasons. When we generate the special `main` implementation for a `@UIApplicationMain` class, we want to call the original function from Objective-C, so pick that one where there are multiple overloads to choose from. Fixes rdar://problem/42352695.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
The source compat suite "failed" with a bunch of UPASSes. Expected? Do we have known breakage due to the UIApplicationMain issue? The compatibility suite passed with the master branch version of this patch. |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Overloading
UIApplicationMainin the UIKit overlay would cause an assertion failure.Scope: Allows a compatibility break introduced by changes to the iOS SDK to be handled in the overlay.
Issue: rdar://problem/42352695
Risk: Low. Replaces an assertion failure on overloading with a check to filter out non-ObjC-defined declarations of UIApplicationMain.
Testing: Swift CI, compatibility suite
Reviewed by: @slavapestov