[test] add test feature static_stdlib #1806
Conversation
Add a test feature flag static_stdlib, which is enabled if the user builds the static libraries. We also add the substitution %target-static-stdlib-path which gives the path of the static stdlib. These features allow testing specifically for the static standard library.
|
To review, it would be helpful to understand better what you're trying to do with this. For example, it seems to me that to get cheaply a lot of coverage for the static library we would just need to add a mode that changes the default compiler invocation to use the static library (just like we already have one that uses |
Yes, that is the subject of SR-730. I will be PRing that, and when I do, its test coverage will rely on a However there are more problems here than merely driver flags. For example, currently any program linked with the static standard library on Linux (e.g. supposing we completely bypass the driver) has broken protocol conformance due to a quirk of the Linux runtime. You can read more about that also on SR-730. I will also be PRing that, and when I do, its test coverage will similarly rely on a Static stdlib (on Linux, anyway) is very, very badly broken right now. This is in part because there is no test coverage, because test coverage is too hard to write, so problems are not found. Obviously would be great to reuse all existing tests with a flag, but we are many PRs away from that being feasible. Right now not even "hello world" will link properly on Linux, and IMO the bugs are sufficiently separate that they should be separate PRs. |
|
@swift-ci test and merge |
What's in this pull request?
I intend to PR some tests (not shown here) which involve working with the static standard library ("static stdlib"). It is hard to write these tests right now, and that is quite possibly why no tests involving static stdlib were written, leading to various highly complex bugs in static stdlib behavior that have gone unnoticed (not shown here).
The static standard library is not built by default (e.g.
build-script -tdoes not build it) and so these tests would be only appropriate to run if static stdlib was built.This PR adds:
Resolved bug number: (SR-)
This is involved in, but does not resolve, SR-730
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.