Skip to content

Revert "[ConstraintSystem] Fix the ordering of functions with optional parame…" #18073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jul 19, 2018

Reverts #17855

It turns out this needs a bit more work to avoid source compatibility problems.

For example we consider the self.x in the interpolation below to be ambiguous with these changes whereas we previously didn't.

class C {
  var x: Int?
  func x(_ y: Int) {}
  func x(_ y: Float) {
    let _ = "\(String(describing: self.x))"
  }
}

@rudkx
Copy link
Contributor Author

rudkx commented Jul 19, 2018

@swift-ci Please smoke test and merge

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was so hopeful that it'll help me to merge my changes to cache but I guess I'll have to wait a bit longer...

@swift-ci swift-ci merged commit 8bedc61 into master Jul 19, 2018
@rudkx rudkx deleted the revert-17855-rdar19748710 branch July 19, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants