[libSyntax] Record reused node IDs #18078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
nkcsgexi
approved these changes
Jul 19, 2018
lib/Parse/SyntaxParsingCache.cpp
Outdated
| : ReusedNodeIds(ReusedNodeIds) {} | ||
|
|
||
| const std::vector<SyntaxReuseRegion> &getReusedRegions() { | ||
| std::sort(ReusedRegions.begin(), ReusedRegions.end(), [](const SyntaxReuseRegion &Lhs, const SyntaxReuseRegion &Rhs) -> bool { |
There was a problem hiding this comment.
Nit: 80 column; otherwise LGTM!
nkcsgexi
reviewed
Jul 19, 2018
| /// post-edit file. | ||
| std::vector<SyntaxReuseRegion> getReusedRanges() const { | ||
| return ReusedRanges; | ||
| const std::unordered_set<unsigned> &getReusedNodeIds() const { |
There was a problem hiding this comment.
It would be good to have a type alias of unsigned as the ID type, so we can search more easily.
This is cheaper than recording reused region offsets and the reused node IDs will later be used to incrementally transfer the syntax to SwiftSyntax.
ahoppen
force-pushed
the
01#2-record-reused-node-ids
branch
from
90bacc1 to
c8226d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cheaper than recording reused region offsets and the reused node IDs will later be used to incrementally transfer the syntax to SwiftSyntax.