[Type checker] Move forcing of overridden/@objc/dynamic into finalizeType(). #18101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type(). As part of factoring overridden decls/@objc/dynamic computation into requests for the request-evaluator, I forced computation of this information as part of requestMemberLayout. This is incorrect: requestMemberLayout() is meant only to trigger finalization of the enclosing class, which is responsible for making sure the type can be properly laid out. Move the newly-introduced forcing logic into finalizeType() where it belongs. Thanks to @slavapestov for describing the intent here.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of factoring overridden decls/@objc/dynamic computation into
requests for the request-evaluator, I forced computation of this
information as part of requestMemberLayout. This is incorrect:
requestMemberLayout() is meant only to trigger finalization of the
enclosing class, which is responsible for making sure the type can be
properly laid out. Move the newly-introduced forcing logic into
finalizeType() where it belongs.
Thanks to @slavapestov for describing the intent here.