[Sema] Fix inappropriate diagnostics of access control for member declared in private extensions. #18105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for members in private extensions. When a `fileprivate` method is declared in a `private` extension, a warning is raised since access level `fileprivate` is literally higher than `private`. This is not appropriate because extensions are top level declarations, for which `private` and `fileprivate` are equivalent. This patch stops such warnings. Resolves: SR-8306.
jrose-apple
approved these changes
Jul 20, 2018
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
fileprivatemethod is declared in aprivateextension, a warning is raised since access levelfileprivateis literally higher thanprivate. This is not appropriate because extensions are top level declarations, for whichprivateandfileprivateare equivalent.This patch stops such warnings, and improves fix-it messages. Consider the case below. The original fix-it suggests overly downgrading to
private. This patch makes itfileprivate, which makes more sense.private extension Foo { public func foo() {} ^~~~~~ - private + fileprivate }Resolves SR-8306.