-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Build the standard library as Swift 5 #18121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke benchmark |
@swift-ci please test source compatibility |
cmake/modules/SwiftSource.cmake
Outdated
@@ -259,7 +259,7 @@ function(_compile_swift_files | |||
|
|||
# Force swift 4 compatibility mode for Standard Library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to update the comment too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty weird, but no, yeah.
Build comment file:Optimized (O)Regression (16)
Improvement (16)
No Changes (428)
Hardware Overview
|
@slavapestov benchmarks don't look harmed |
Thanks for the crash report, I’ll take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — I believe we added the fixed-layout annotations to EncodingError
and DecodingError
back in airspeedswift@a24998a; I think it's reasonable to remove them now.
@airspeedswift Should we remove any other |
417660e
to
3db889c
Compare
@swift-ci please test |
Build failed |
@itaiferber Hmm... possibly, but it's pretty generic so it could take quite a hit. How much benchmarking coverage does it have? |
Build failed |
Gah. Works on my machine™️. |
@swift-ci please test macOS platform |
Build failed |
…en on slow paths anyway)
3db889c
to
d868362
Compare
@swift-ci please smoke benchmark |
@swift-ci please smoke test compiler performance |
@swift-ci please test |
Build failed |
Build failed |
Build comment file:Optimized (O)Regression (16)
Improvement (15)
No Changes (429)
Hardware Overview
|
4.2 was a non-event so figured ¯\(ツ)/¯
Not much needed changing over #17580, mostly warnings:
Unicode.*
typealiases, for a later patchFloatingPointRoundingRule
removeddone in [stdlib] Clean up debug printing code #18126@inlinable
from debugger support – shouldn't be necessaryEndodingError
andDecodingError
resilient.@itaiferber are you ok with making those two errors resilient? Seems like they'll only occur on slow paths so the perf hit shouldn't matter, and allows for future changes.
@slavapestov making them resilient causes
deserialize_coregraphics.swift
to fail: