Skip to content

[stdlib] Take several underscored stdlib functions private #18134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2018
Merged

[stdlib] Take several underscored stdlib functions private #18134

merged 8 commits into from
Jul 25, 2018

Conversation

airspeedswift
Copy link
Member

In many cases, these have leaked out unnecessarily into the SDK or tests. In a few cases, they're needed to do the tests, and might need some work to test in different ways. Mostly just testing perf and compat impact for now.

Starting with various assertiony things.

@airspeedswift
Copy link
Member Author

@swift-ci please smoke benchmark

@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for Kingfisher, ReactiveCocoa

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 9,381,812 9,381,812 0 0.0%
time.swift-driver.wall 19.4s 19.2s -188.2ms -0.97%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 5,870 5,870 0 0.0%
AST.NumLoadedModules 1,281 1,281 0 0.0%
AST.NumTotalClangImportedEntities 17,540 17,540 0 0.0%
AST.NumUsedConformances 1,283 1,283 0 0.0%
IRModule.NumIRBasicBlocks 31,258 31,258 0 0.0%
IRModule.NumIRFunctions 17,189 17,189 0 0.0%
IRModule.NumIRGlobals 14,002 14,002 0 0.0%
IRModule.NumIRInsts 437,759 437,759 0 0.0%
IRModule.NumIRValueSymbols 29,058 29,058 0 0.0%
LLVM.NumLLVMBytesOutput 9,381,812 9,381,812 0 0.0%
SILModule.NumSILGenFunctions 8,036 8,036 0 0.0%
SILModule.NumSILOptFunctions 10,969 10,969 0 0.0%
Sema.NumConformancesDeserialized 41,033 41,033 0 0.0%
Sema.NumConstraintScopes 73,671 73,671 0 0.0%
Sema.NumDeclsDeserialized 258,968 258,968 0 0.0%
Sema.NumDeclsValidated 27,541 27,541 0 0.0%
Sema.NumFunctionsTypechecked 4,974 4,974 0 0.0%
Sema.NumGenericSignatureBuilders 11,889 11,889 0 0.0%
Sema.NumLazyGenericEnvironments 49,938 49,938 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 5,929 5,929 0 0.0%
Sema.NumLazyIterableDeclContexts 38,430 38,430 0 0.0%
Sema.NumTypesDeserialized 276,770 276,770 0 0.0%
Sema.NumTypesValidated 35,842 35,842 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 10,602,428 10,602,428 0 0.0%
time.swift-driver.wall 32.8s 32.9s 19.0ms 0.06%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,411 1,411 0 0.0%
AST.NumLoadedModules 100 100 0 0.0%
AST.NumTotalClangImportedEntities 4,936 4,936 0 0.0%
AST.NumUsedConformances 1,286 1,286 0 0.0%
IRModule.NumIRBasicBlocks 34,588 34,588 0 0.0%
IRModule.NumIRFunctions 15,395 15,395 0 0.0%
IRModule.NumIRGlobals 13,841 13,841 0 0.0%
IRModule.NumIRInsts 341,372 341,372 0 0.0%
IRModule.NumIRValueSymbols 27,470 27,470 0 0.0%
LLVM.NumLLVMBytesOutput 10,602,428 10,602,428 0 0.0%
SILModule.NumSILGenFunctions 6,179 6,179 0 0.0%
SILModule.NumSILOptFunctions 9,468 9,468 0 0.0%
Sema.NumConformancesDeserialized 19,670 19,670 0 0.0%
Sema.NumConstraintScopes 72,267 72,267 0 0.0%
Sema.NumDeclsDeserialized 57,219 57,219 0 0.0%
Sema.NumDeclsValidated 20,786 20,786 0 0.0%
Sema.NumFunctionsTypechecked 3,079 3,079 0 0.0%
Sema.NumGenericSignatureBuilders 2,846 2,846 0 0.0%
Sema.NumLazyGenericEnvironments 9,702 9,702 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 1,359 1,359 0 0.0%
Sema.NumLazyIterableDeclContexts 5,673 5,673 0 0.0%
Sema.NumTypesDeserialized 72,275 72,275 0 0.0%
Sema.NumTypesValidated 17,086 17,086 0 0.0%

@swift-ci
Copy link
Contributor

Build comment file:

Optimized (O)

Regression (8)
TEST OLD NEW DELTA SPEEDUP
DataAppendDataSmallToLarge 21758 36788 +69.1% 0.59x (?)
DataAppendDataMediumToLarge 22346 32382 +44.9% 0.69x
SevenBoom 841 1021 +21.4% 0.82x (?)
StringBuilderLong 1343 1611 +20.0% 0.83x (?)
DataReplaceSmallBuffer 9000 10437 +16.0% 0.86x
ObjectiveCBridgeToNSSet 16871 19177 +13.7% 0.88x
ObjectiveCBridgeFromNSSetAnyObject 48532 53139 +9.5% 0.91x (?)
IterateData 1401 1530 +9.2% 0.92x
Improvement (9)
TEST OLD NEW DELTA SPEEDUP
DictionaryBridgeToObjC_Access 1031 917 -11.1% 1.12x
ObjectiveCBridgeStubToNSDate 15997 14524 -9.2% 1.10x
AnyHashableWithAClass 99323 91077 -8.3% 1.09x
WordSplitUTF16 11954 10989 -8.1% 1.09x
ObjectiveCBridgeFromNSArrayAnyObjectForced 5894 5441 -7.7% 1.08x (?)
PopFrontUnsafePointer 9496 8784 -7.5% 1.08x (?)
UTF8Decode_InitFromBytes_ascii 525 494 -5.9% 1.06x (?)
MapReduceLazyCollectionShort 38 36 -5.3% 1.06x (?)
ObjectiveCBridgeFromNSSetAnyObjectToString 74045 70483 -4.8% 1.05x (?)
No Changes (443)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 3788 3780 -0.2% 1.00x (?)
Array2D 2863 2854 -0.3% 1.00x (?)
ArrayAppend 1077 1077 +0.0% 1.00x
ArrayAppendArrayOfInt 798 800 +0.3% 1.00x (?)
ArrayAppendAscii 3868 3853 -0.4% 1.00x (?)
ArrayAppendAsciiSubstring 25359 25355 -0.0% 1.00x (?)
ArrayAppendFromGeneric 798 801 +0.4% 1.00x (?)
ArrayAppendGenericStructs 1433 1430 -0.2% 1.00x (?)
ArrayAppendLatin1 41589 41609 +0.0% 1.00x (?)
ArrayAppendLatin1Substring 142097 142089 -0.0% 1.00x (?)
ArrayAppendLazyMap 1343 1343 +0.0% 1.00x
ArrayAppendOptionals 1434 1434 +0.0% 1.00x
ArrayAppendRepeatCol 1339 1337 -0.1% 1.00x (?)
ArrayAppendReserved 808 805 -0.4% 1.00x
ArrayAppendSequence 1121 1126 +0.4% 1.00x
ArrayAppendStrings 6335 6333 -0.0% 1.00x (?)
ArrayAppendToFromGeneric 802 802 +0.0% 1.00x
ArrayAppendToGeneric 807 805 -0.2% 1.00x (?)
ArrayAppendUTF16 41151 41076 -0.2% 1.00x (?)
ArrayAppendUTF16Substring 140241 140372 +0.1% 1.00x (?)
ArrayInClass 86 86 +0.0% 1.00x
ArrayLiteral 0 0 +0.0% 1.00x
ArrayOfGenericPOD2 152 152 +0.0% 1.00x
ArrayOfGenericRef 4374 4375 +0.0% 1.00x (?)
ArrayOfPOD 185 185 +0.0% 1.00x
ArrayOfRef 4373 4368 -0.1% 1.00x (?)
ArrayPlusEqualArrayOfInt 797 802 +0.6% 0.99x
ArrayPlusEqualFiveElementCollection 5445 5400 -0.8% 1.01x (?)
ArrayPlusEqualSingleElementCollection 1078 1077 -0.1% 1.00x
ArrayPlusEqualThreeElements 1657 1658 +0.1% 1.00x (?)
ArraySubscript 1576 1574 -0.1% 1.00x (?)
ArrayValueProp 8 8 +0.0% 1.00x
ArrayValueProp2 8 8 +0.0% 1.00x
ArrayValueProp3 8 8 +0.0% 1.00x
ArrayValueProp4 8 8 +0.0% 1.00x
BinaryFloatingPointPropertiesBinade 25 25 +0.0% 1.00x
BinaryFloatingPointPropertiesNextUp 28 28 +0.0% 1.00x
BinaryFloatingPointPropertiesUlp 37 37 +0.0% 1.00x
BitCount 202 202 +0.0% 1.00x
ByteSwap 107 106 -0.9% 1.01x (?)
COWArrayGuaranteedParameterOverhead 10142 10102 -0.4% 1.00x (?)
COWTree 3647 3669 +0.6% 0.99x (?)
CSVParsing 656550 657056 +0.1% 1.00x (?)
CSVParsingAlt 813248 813368 +0.0% 1.00x (?)
CSVParsingAltIndices 339052 339173 +0.0% 1.00x (?)
CStringLongAscii 4191 4195 +0.1% 1.00x (?)
CStringLongNonAscii 2439 2436 -0.1% 1.00x (?)
CStringShortAscii 3338 3334 -0.1% 1.00x (?)
Calculator 215 215 +0.0% 1.00x
CaptureProp 4108 4096 -0.3% 1.00x
ChainedFilterMap 1248 1247 -0.1% 1.00x (?)
CharIndexing_ascii_unicodeScalars 17323 17325 +0.0% 1.00x (?)
CharIndexing_ascii_unicodeScalars_Backwards 15825 15832 +0.0% 1.00x (?)
CharIndexing_chinese_unicodeScalars 13132 13126 -0.0% 1.00x (?)
CharIndexing_chinese_unicodeScalars_Backwards 12006 12002 -0.0% 1.00x (?)
CharIndexing_japanese_unicodeScalars 20727 20739 +0.1% 1.00x (?)
CharIndexing_japanese_unicodeScalars_Backwards 18954 18962 +0.0% 1.00x (?)
CharIndexing_korean_unicodeScalars 16792 16805 +0.1% 1.00x (?)
CharIndexing_korean_unicodeScalars_Backwards 15353 15360 +0.0% 1.00x
CharIndexing_punctuatedJapanese_unicodeScalars 3156 3138 -0.6% 1.01x (?)
CharIndexing_punctuatedJapanese_unicodeScalars_Backwards 2888 2888 +0.0% 1.00x
CharIndexing_punctuated_unicodeScalars 3919 3921 +0.1% 1.00x
CharIndexing_punctuated_unicodeScalars_Backwards 3607 3608 +0.0% 1.00x (?)
CharIndexing_russian_unicodeScalars 14426 14428 +0.0% 1.00x (?)
CharIndexing_russian_unicodeScalars_Backwards 13195 13196 +0.0% 1.00x (?)
CharIndexing_tweet_unicodeScalars 34403 34380 -0.1% 1.00x (?)
CharIndexing_tweet_unicodeScalars_Backwards 31265 31262 -0.0% 1.00x (?)
CharIndexing_utf16_unicodeScalars 23128 23128 +0.0% 1.00x
CharIndexing_utf16_unicodeScalars_Backwards 23275 23324 +0.2% 1.00x
CharIteration_ascii_unicodeScalars 21627 21615 -0.1% 1.00x (?)
CharIteration_ascii_unicodeScalars_Backwards 14367 14366 -0.0% 1.00x (?)
CharIteration_chinese_unicodeScalars 16371 16373 +0.0% 1.00x (?)
CharIteration_chinese_unicodeScalars_Backwards 10891 10884 -0.1% 1.00x (?)
CharIteration_japanese_unicodeScalars 25921 25908 -0.1% 1.00x (?)
CharIteration_japanese_unicodeScalars_Backwards 17196 17196 +0.0% 1.00x
CharIteration_korean_unicodeScalars 20973 20962 -0.1% 1.00x (?)
CharIteration_korean_unicodeScalars_Backwards 13928 13932 +0.0% 1.00x (?)
CharIteration_punctuatedJapanese_unicodeScalars 3873 3871 -0.1% 1.00x (?)
CharIteration_punctuatedJapanese_unicodeScalars_Backwards 2613 2614 +0.0% 1.00x (?)
CharIteration_punctuated_unicodeScalars 4855 4857 +0.0% 1.00x (?)
CharIteration_punctuated_unicodeScalars_Backwards 3268 3268 +0.0% 1.00x
CharIteration_russian_unicodeScalars 18005 18011 +0.0% 1.00x (?)
CharIteration_russian_unicodeScalars_Backwards 11973 11975 +0.0% 1.00x (?)
CharIteration_tweet_unicodeScalars 42688 42715 +0.1% 1.00x (?)
CharIteration_tweet_unicodeScalars_Backwards 28735 28722 -0.0% 1.00x (?)
CharIteration_utf16_unicodeScalars 28245 28252 +0.0% 1.00x (?)
CharIteration_utf16_unicodeScalars_Backwards 17652 17654 +0.0% 1.00x (?)
CharacterLiteralsLarge 5874 5872 -0.0% 1.00x (?)
CharacterLiteralsSmall 217 217 +0.0% 1.00x
CharacterPropertiesFetch 4608 4587 -0.5% 1.00x (?)
CharacterPropertiesPrecomputed 1002 1003 +0.1% 1.00x (?)
CharacterPropertiesStashed 1794 1803 +0.5% 1.00x (?)
CharacterPropertiesStashedMemo 1568 1557 -0.7% 1.01x (?)
Chars 1022 1022 +0.0% 1.00x
ClassArrayGetter 15 15 +0.0% 1.00x
Combos 494 494 +0.0% 1.00x
DataAccessBytes 1140 1143 +0.3% 1.00x
DataAppendArray 5060 5198 +2.7% 0.97x (?)
DataAppendBytes 4879 4813 -1.4% 1.01x (?)
DataAppendDataLargeToLarge 68456 67519 -1.4% 1.01x (?)
DataAppendDataLargeToMedium 35552 35826 +0.8% 0.99x (?)
DataAppendDataLargeToSmall 34512 34521 +0.0% 1.00x (?)
DataAppendDataMediumToMedium 6735 6898 +2.4% 0.98x (?)
DataAppendDataMediumToSmall 6073 5948 -2.1% 1.02x (?)
DataAppendDataSmallToMedium 6299 6179 -1.9% 1.02x (?)
DataAppendDataSmallToSmall 6209 6039 -2.7% 1.03x (?)
DataAppendSequence 20131 20687 +2.8% 0.97x
DataCopyBytes 457 457 +0.0% 1.00x
DataCount 37 37 +0.0% 1.00x
DataMutateBytes 3937 3875 -1.6% 1.02x
DataReplaceLarge 37077 36282 -2.1% 1.02x (?)
DataReplaceLargeBuffer 59276 58564 -1.2% 1.01x (?)
DataReplaceMedium 8033 7682 -4.4% 1.05x (?)
DataReplaceMediumBuffer 12796 12233 -4.4% 1.05x (?)
DataReplaceSmall 5608 5632 +0.4% 1.00x (?)
DataReset 2882 2889 +0.2% 1.00x (?)
DataSetCount 570 561 -1.6% 1.02x (?)
DataSubscript 220 220 +0.0% 1.00x
DictOfArraysToArrayOfDicts 771 789 +2.3% 0.98x (?)
Dictionary 517 517 +0.0% 1.00x
Dictionary2 633 633 +0.0% 1.00x
Dictionary2OfObjects 2085 2086 +0.0% 1.00x (?)
Dictionary3 225 225 +0.0% 1.00x
Dictionary3OfObjects 737 738 +0.1% 1.00x (?)
Dictionary4 321 322 +0.3% 1.00x (?)
Dictionary4Legacy 716 716 +0.0% 1.00x
Dictionary4OfObjects 433 433 +0.0% 1.00x
Dictionary4OfObjectsLegacy 933 933 +0.0% 1.00x
DictionaryBridge 1300 1244 -4.3% 1.05x (?)
DictionaryBridgeToObjC_Bridge 19 19 +0.0% 1.00x
DictionaryBridgeToObjC_BulkAccess 166 167 +0.6% 0.99x (?)
DictionaryCompactMapValuesOfCastValue 14480 14368 -0.8% 1.01x (?)
DictionaryCompactMapValuesOfNilValue 7279 7320 +0.6% 0.99x (?)
DictionaryCopy 107947 107838 -0.1% 1.00x (?)
DictionaryFilter 107646 107629 -0.0% 1.00x (?)
DictionaryGroup 217 217 +0.0% 1.00x
DictionaryGroupOfObjects 2110 2112 +0.1% 1.00x (?)
DictionaryKeysContainsCocoa 42 40 -4.8% 1.05x (?)
DictionaryKeysContainsNative 31 31 +0.0% 1.00x
DictionaryLiteral 1895 1898 +0.2% 1.00x (?)
DictionaryOfObjects 2379 2418 +1.6% 0.98x (?)
DictionaryRemove 4242 4251 +0.2% 1.00x (?)
DictionaryRemoveOfObjects 25661 25685 +0.1% 1.00x (?)
DictionarySubscriptDefaultMutation 266 266 +0.0% 1.00x
DictionarySubscriptDefaultMutationArray 618 619 +0.2% 1.00x (?)
DictionarySubscriptDefaultMutationArrayOfObjects 4020 4015 -0.1% 1.00x (?)
DictionarySubscriptDefaultMutationOfObjects 1718 1718 +0.0% 1.00x
DictionarySwap 1035 1035 +0.0% 1.00x
DictionarySwapAt 7034 7022 -0.2% 1.00x (?)
DictionarySwapAtOfObjects 52375 52395 +0.0% 1.00x (?)
DictionarySwapOfObjects 8764 8791 +0.3% 1.00x (?)
DoubleWidthDivision 0 0 +0.0% 1.00x
DropFirstAnyCollection 76 76 +0.0% 1.00x
DropFirstAnyCollectionLazy 65370 65408 +0.1% 1.00x (?)
DropFirstAnySeqCRangeIter 93 93 +0.0% 1.00x
DropFirstAnySeqCRangeIterLazy 93 93 +0.0% 1.00x
DropFirstAnySeqCntRange 71 71 +0.0% 1.00x
DropFirstAnySeqCntRangeLazy 71 71 +0.0% 1.00x
DropFirstAnySequence 1843 1842 -0.1% 1.00x
DropFirstAnySequenceLazy 1842 1842 +0.0% 1.00x
DropFirstArray 35 35 +0.0% 1.00x
DropFirstArrayLazy 35 35 +0.0% 1.00x
DropFirstCountableRange 35 35 +0.0% 1.00x
DropFirstCountableRangeLazy 35 35 +0.0% 1.00x
DropFirstSequence 2682 2680 -0.1% 1.00x (?)
DropFirstSequenceLazy 2775 2774 -0.0% 1.00x (?)
DropLastAnyCollection 99 99 +0.0% 1.00x
DropLastAnyCollectionLazy 21616 21669 +0.2% 1.00x (?)
DropLastAnySeqCRangeIter 3304 3307 +0.1% 1.00x (?)
DropLastAnySeqCRangeIterLazy 3283 3300 +0.5% 0.99x (?)
DropLastAnySeqCntRange 21 21 +0.0% 1.00x
DropLastAnySeqCntRangeLazy 21 21 +0.0% 1.00x
DropLastAnySequence 4984 4981 -0.1% 1.00x (?)
DropLastAnySequenceLazy 5171 5182 +0.2% 1.00x
DropLastCountableRange 15 15 +0.0% 1.00x
DropLastCountableRangeLazy 16 16 +0.0% 1.00x
DropLastSequence 697 696 -0.1% 1.00x (?)
DropLastSequenceLazy 697 697 +0.0% 1.00x
DropWhileAnyCollection 100 100 +0.0% 1.00x
DropWhileAnyCollectionLazy 130 130 +0.0% 1.00x
DropWhileAnySeqCRangeIter 75 76 +1.3% 0.99x (?)
DropWhileAnySeqCRangeIterLazy 130 130 +0.0% 1.00x
DropWhileAnySeqCntRange 95 95 +0.0% 1.00x
DropWhileAnySeqCntRangeLazy 130 130 +0.0% 1.00x
DropWhileAnySequence 1861 1861 +0.0% 1.00x
DropWhileAnySequenceLazy 1855 1855 +0.0% 1.00x
DropWhileArrayLazy 88 88 +0.0% 1.00x
DropWhileCountableRange 36 36 +0.0% 1.00x
DropWhileCountableRangeLazy 105 105 +0.0% 1.00x
DropWhileSequence 2220 2220 +0.0% 1.00x
DropWhileSequenceLazy 88 88 +0.0% 1.00x
EqualStringSubstring 49 49 +0.0% 1.00x
EqualSubstringString 49 49 +0.0% 1.00x
EqualSubstringSubstring 49 49 +0.0% 1.00x
EqualSubstringSubstringGenericEquatable 49 49 +0.0% 1.00x
ErrorHandling 1209 1221 +1.0% 0.99x (?)
ExclusivityGlobal 5 5 +0.0% 1.00x
ExclusivityIndependent 2 2 +0.0% 1.00x
FatCompactMap 1245 1247 +0.2% 1.00x
FilterEvenUsingReduce 1319 1332 +1.0% 0.99x (?)
FilterEvenUsingReduceInto 159 159 +0.0% 1.00x
FloatingPointPrinting_Double_description_small 21437 21554 +0.5% 0.99x (?)
FloatingPointPrinting_Double_description_uniform 20973 21032 +0.3% 1.00x (?)
FloatingPointPrinting_Double_interpolated 62033 62184 +0.2% 1.00x (?)
FloatingPointPrinting_Float80_description_small 28396 28401 +0.0% 1.00x (?)
FloatingPointPrinting_Float80_description_uniform 27737 27734 -0.0% 1.00x (?)
FloatingPointPrinting_Float80_interpolated 65460 67717 +3.4% 0.97x
FloatingPointPrinting_Float_description_small 5432 5438 +0.1% 1.00x (?)
FloatingPointPrinting_Float_description_uniform 5384 5380 -0.1% 1.00x (?)
FloatingPointPrinting_Float_interpolated 38927 38744 -0.5% 1.00x (?)
FrequenciesUsingReduce 5060 5057 -0.1% 1.00x (?)
FrequenciesUsingReduceInto 1532 1529 -0.2% 1.00x (?)
Hanoi 2136 2120 -0.7% 1.01x
HashTest 951 948 -0.3% 1.00x (?)
Histogram 662 661 -0.2% 1.00x (?)
Integrate 337 337 +0.0% 1.00x
Join 171 172 +0.6% 0.99x
LazilyFilteredArrayContains 38640 38647 +0.0% 1.00x (?)
LazilyFilteredArrays 66570 66643 +0.1% 1.00x (?)
LazilyFilteredRange 3878 3879 +0.0% 1.00x (?)
LessSubstringSubstring 49 49 +0.0% 1.00x
LessSubstringSubstringGenericComparable 49 49 +0.0% 1.00x
LinkedList 7557 7555 -0.0% 1.00x (?)
LuhnAlgoEager 453 453 +0.0% 1.00x
LuhnAlgoLazy 453 453 +0.0% 1.00x
MapReduce 428 428 +0.0% 1.00x
MapReduceAnyCollection 401 400 -0.2% 1.00x (?)
MapReduceAnyCollectionShort 2052 2071 +0.9% 0.99x (?)
MapReduceClass 3013 3014 +0.0% 1.00x (?)
MapReduceClassShort 4549 4610 +1.3% 0.99x (?)
MapReduceLazyCollection 13 13 +0.0% 1.00x
MapReduceLazySequence 86 86 +0.0% 1.00x
MapReduceSequence 466 464 -0.4% 1.00x (?)
MapReduceShort 2012 2013 +0.0% 1.00x (?)
MapReduceShortString 20 20 +0.0% 1.00x
MapReduceString 49 50 +2.0% 0.98x (?)
Memset 215 216 +0.5% 1.00x (?)
MonteCarloE 10393 10394 +0.0% 1.00x (?)
MonteCarloPi 42966 42952 -0.0% 1.00x (?)
NSDictionaryCastToSwift 7202 7149 -0.7% 1.01x (?)
NSError 164 163 -0.6% 1.01x
NSStringConversion 683 689 +0.9% 0.99x
NibbleSort 3461 3462 +0.0% 1.00x (?)
NopDeinit 32066 32076 +0.0% 1.00x (?)
ObjectAllocation 132 132 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObject 26085 27225 +4.4% 0.96x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 45665 46461 +1.7% 0.98x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 44300 45367 +2.4% 0.98x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 117503 112401 -4.3% 1.05x
ObjectiveCBridgeFromNSSetAnyObjectForced 5000 5066 +1.3% 0.99x (?)
ObjectiveCBridgeFromNSString 1262 1258 -0.3% 1.00x
ObjectiveCBridgeFromNSStringForced 2701 2701 +0.0% 1.00x
ObjectiveCBridgeStubDataAppend 6349 6389 +0.6% 0.99x (?)
ObjectiveCBridgeStubDateMutation 401 401 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 35678 34315 -3.8% 1.04x (?)
ObjectiveCBridgeStubFromNSDate 6524 6575 +0.8% 0.99x (?)
ObjectiveCBridgeStubFromNSString 1022 1014 -0.8% 1.01x (?)
ObjectiveCBridgeStubFromNSStringRef 155 156 +0.6% 0.99x
ObjectiveCBridgeStubNSDataAppend 2712 2597 -4.2% 1.04x (?)
ObjectiveCBridgeStubNSDateMutationRef 13287 13487 +1.5% 0.99x
ObjectiveCBridgeStubToArrayOfNSString 39455 39726 +0.7% 0.99x (?)
ObjectiveCBridgeStubToNSDateRef 3427 3427 +0.0% 1.00x
ObjectiveCBridgeStubToNSString 2338 2345 +0.3% 1.00x
ObjectiveCBridgeStubToNSStringRef 116 115 -0.9% 1.01x
ObjectiveCBridgeStubURLAppendPath 286091 284747 -0.5% 1.00x (?)
ObjectiveCBridgeStubURLAppendPathRef 276399 282123 +2.1% 0.98x (?)
ObjectiveCBridgeToNSArray 14553 14918 +2.5% 0.98x (?)
ObjectiveCBridgeToNSDictionary 28240 27489 -2.7% 1.03x (?)
ObjectiveCBridgeToNSString 455 455 +0.0% 1.00x
ObserverClosure 2174 2179 +0.2% 1.00x (?)
ObserverForwarderStruct 1214 1214 +0.0% 1.00x
ObserverPartiallyAppliedMethod 3746 3743 -0.1% 1.00x (?)
ObserverUnappliedMethod 2454 2458 +0.2% 1.00x (?)
OpaqueConsumingUsers 4181 4181 +0.0% 1.00x
OpenClose 65 65 +0.0% 1.00x
PartialApplyDynamicType 0 0 +0.0% 1.00x
Phonebook 7114 7111 -0.0% 1.00x (?)
PointerArithmetics 31488 31500 +0.0% 1.00x (?)
PolymorphicCalls 25 25 +0.0% 1.00x
PopFrontArray 1966 1971 +0.3% 1.00x (?)
PopFrontArrayGeneric 2002 1977 -1.2% 1.01x (?)
PrefixAnyCollection 76 76 +0.0% 1.00x
PrefixAnyCollectionLazy 64757 64800 +0.1% 1.00x (?)
PrefixAnySeqCRangeIter 40 40 +0.0% 1.00x
PrefixAnySeqCRangeIterLazy 40 40 +0.0% 1.00x
PrefixAnySeqCntRange 71 71 +0.0% 1.00x
PrefixAnySeqCntRangeLazy 71 71 +0.0% 1.00x
PrefixAnySequence 1379 1378 -0.1% 1.00x
PrefixAnySequenceLazy 1378 1379 +0.1% 1.00x (?)
PrefixArray 35 35 +0.0% 1.00x
PrefixArrayLazy 35 35 +0.0% 1.00x
PrefixCountableRange 35 35 +0.0% 1.00x
PrefixCountableRangeLazy 35 35 +0.0% 1.00x
PrefixSequence 2223 2224 +0.0% 1.00x
PrefixSequenceLazy 2276 2274 -0.1% 1.00x (?)
PrefixWhileAnyCollection 147 147 +0.0% 1.00x
PrefixWhileAnyCollectionLazy 71 71 +0.0% 1.00x
PrefixWhileAnySeqCRangeIter 404 404 +0.0% 1.00x
PrefixWhileAnySeqCRangeIterLazy 89 89 +0.0% 1.00x
PrefixWhileAnySeqCntRange 142 142 +0.0% 1.00x
PrefixWhileAnySeqCntRangeLazy 71 71 +0.0% 1.00x
PrefixWhileAnySequence 1540 1539 -0.1% 1.00x (?)
PrefixWhileAnySequenceLazy 1391 1391 +0.0% 1.00x
PrefixWhileArray 88 88 +0.0% 1.00x
PrefixWhileArrayLazy 70 70 +0.0% 1.00x
PrefixWhileCountableRange 36 36 +0.0% 1.00x
PrefixWhileCountableRangeLazy 35 35 +0.0% 1.00x
PrefixWhileSequence 381 381 +0.0% 1.00x
PrefixWhileSequenceLazy 52 52 +0.0% 1.00x
Prims 920 924 +0.4% 1.00x (?)
PrimsSplit 930 935 +0.5% 0.99x (?)
QueueConcrete 1150 1150 +0.0% 1.00x
QueueGeneric 1135 1135 +0.0% 1.00x
RC4 149 149 +0.0% 1.00x
RGBHistogram 2589 2596 +0.3% 1.00x (?)
RGBHistogramOfObjects 20303 20337 +0.2% 1.00x (?)
Radix2CooleyTukey 12427 12760 +2.7% 0.97x (?)
Radix2CooleyTukeyf 9195 9049 -1.6% 1.02x (?)
RandomDoubleDef 26638 26610 -0.1% 1.00x (?)
RandomDoubleLCG 2176 2177 +0.0% 1.00x
RandomIntegersDef 24320 24314 -0.0% 1.00x (?)
RandomIntegersLCG 173 173 +0.0% 1.00x
RandomShuffleDef 808559 810824 +0.3% 1.00x (?)
RandomShuffleLCG 57805 56556 -2.2% 1.02x (?)
RangeAssignment 366 378 +3.3% 0.97x (?)
RangeIterationSigned 200 200 +0.0% 1.00x
RangeReplaceableCollectionPlusDefault 1063 1064 +0.1% 1.00x
RecursiveOwnedParameter 115 115 +0.0% 1.00x
RemoveWhereFilterInts 49 49 +0.0% 1.00x
RemoveWhereFilterString 255 244 -4.3% 1.05x (?)
RemoveWhereFilterStrings 437 438 +0.2% 1.00x (?)
RemoveWhereMoveInts 15 15 +0.0% 1.00x
RemoveWhereMoveStrings 710 709 -0.1% 1.00x (?)
RemoveWhereQuadraticInts 1293 1294 +0.1% 1.00x (?)
RemoveWhereQuadraticString 385 382 -0.8% 1.01x (?)
RemoveWhereQuadraticStrings 2764 2763 -0.0% 1.00x (?)
RemoveWhereSwapInts 19 20 +5.3% 0.95x
RemoveWhereSwapStrings 858 860 +0.2% 1.00x (?)
ReversedArray 57 57 +0.0% 1.00x
ReversedBidirectional 16827 16820 -0.0% 1.00x (?)
ReversedDictionary 271 271 +0.0% 1.00x
RomanNumbers 82369 82366 -0.0% 1.00x (?)
SequenceAlgosAnySequence 11972 11956 -0.1% 1.00x
SequenceAlgosArray 1579 1579 +0.0% 1.00x
SequenceAlgosContiguousArray 1578 1568 -0.6% 1.01x (?)
SequenceAlgosList 1359 1359 +0.0% 1.00x
SequenceAlgosRange 2577 2577 +0.0% 1.00x
SequenceAlgosUnfoldSequence 1102 1102 +0.0% 1.00x
SetExclusiveOr 5142 5130 -0.2% 1.00x (?)
SetExclusiveOr_OfObjects 11636 11618 -0.2% 1.00x (?)
SetIntersect 700 700 +0.0% 1.00x
SetIntersect_OfObjects 1765 1764 -0.1% 1.00x (?)
SetIsSubsetOf 344 344 +0.0% 1.00x
SetIsSubsetOf_OfObjects 441 442 +0.2% 1.00x
SetUnion 4529 4522 -0.2% 1.00x (?)
SetUnion_OfObjects 10131 10140 +0.1% 1.00x (?)
Sim2DArray 417 417 +0.0% 1.00x
SortLargeExistentials 5560 5560 +0.0% 1.00x
SortLettersInPlace 976 962 -1.4% 1.01x
SortSortedStrings 705 705 +0.0% 1.00x
SortStrings 1492 1490 -0.1% 1.00x
SortStringsUnicode 2081 2081 +0.0% 1.00x
StackPromo 24521 24369 -0.6% 1.01x (?)
StaticArray 9 9 +0.0% 1.00x
StrComplexWalk 1776 1776 +0.0% 1.00x
StrToInt 3216 3174 -1.3% 1.01x (?)
StringAdder 562 561 -0.2% 1.00x
StringBuilder 497 497 +0.0% 1.00x
StringBuilderSmallReservingCapacity 507 507 +0.0% 1.00x
StringBuilderWithLongSubstring 1439 1478 +2.7% 0.97x
StringComparison_abnormal 815 815 +0.0% 1.00x
StringComparison_ascii 1014 1015 +0.1% 1.00x (?)
StringComparison_emoji 848 848 +0.0% 1.00x
StringComparison_fastPrenormal 830 830 +0.0% 1.00x
StringComparison_latin1 652 652 +0.0% 1.00x
StringComparison_longSharedPrefix 947 946 -0.1% 1.00x (?)
StringComparison_nonBMPSlowestPrenormal 1674 1675 +0.1% 1.00x (?)
StringComparison_slowerPrenormal 1790 1797 +0.4% 1.00x
StringComparison_zalgo 112263 112369 +0.1% 1.00x (?)
StringEdits 167450 167497 +0.0% 1.00x (?)
StringEnumRawValueInitialization 864 865 +0.1% 1.00x (?)
StringEqualPointerComparison 286 286 +0.0% 1.00x
StringFromLongWholeSubstring 21 21 +0.0% 1.00x
StringFromLongWholeSubstringGeneric 21 21 +0.0% 1.00x
StringHasPrefixAscii 2205 2205 +0.0% 1.00x
StringHasPrefixUnicode 101990 100033 -1.9% 1.02x (?)
StringHasSuffixAscii 2291 2291 +0.0% 1.00x
StringHasSuffixUnicode 101016 100697 -0.3% 1.00x (?)
StringHashing_abnormal 1352 1356 +0.3% 1.00x (?)
StringHashing_ascii 33 33 +0.0% 1.00x
StringHashing_emoji 1895 1906 +0.6% 0.99x (?)
StringHashing_fastPrenormal 8361 8341 -0.2% 1.00x (?)
StringHashing_latin1 2555 2548 -0.3% 1.00x (?)
StringHashing_longSharedPrefix 7949 7964 +0.2% 1.00x (?)
StringHashing_nonBMPSlowestPrenormal 2083 2096 +0.6% 0.99x (?)
StringHashing_slowerPrenormal 2729 2731 +0.1% 1.00x (?)
StringHashing_zalgo 3486 3518 +0.9% 0.99x
StringInterpolation 9216 9113 -1.1% 1.01x (?)
StringInterpolationManySmallSegments 18849 18844 -0.0% 1.00x (?)
StringInterpolationSmall 4310 4275 -0.8% 1.01x (?)
StringMatch 11980 11963 -0.1% 1.00x (?)
StringRemoveDupes 482 479 -0.6% 1.01x (?)
StringUTF16Builder 2635 2638 +0.1% 1.00x (?)
StringUTF16SubstringBuilder 5603 5642 +0.7% 0.99x (?)
StringWalk 1553 1552 -0.1% 1.00x (?)
StringWithCString 125232 125283 +0.0% 1.00x (?)
StringWordBuilder 2366 2360 -0.3% 1.00x (?)
StringWordBuilderReservingCapacity 1964 1959 -0.3% 1.00x (?)
SubstringComparable 13 13 +0.0% 1.00x
SubstringEqualString 612 615 +0.5% 1.00x (?)
SubstringEquatable 1444 1441 -0.2% 1.00x (?)
SubstringFromLongString 10 10 +0.0% 1.00x
SubstringFromLongStringGeneric 74 74 +0.0% 1.00x
SuffixAnyCollection 52 52 +0.0% 1.00x
SuffixAnyCollectionLazy 21721 21882 +0.7% 0.99x (?)
SuffixAnySeqCRangeIter 3585 3597 +0.3% 1.00x (?)
SuffixAnySeqCRangeIterLazy 3582 3585 +0.1% 1.00x (?)
SuffixAnySeqCntRange 24 24 +0.0% 1.00x
SuffixAnySeqCntRangeLazy 24 24 +0.0% 1.00x
SuffixAnySequence 4913 4922 +0.2% 1.00x (?)
SuffixAnySequenceLazy 5069 5068 -0.0% 1.00x (?)
SuffixCountableRange 13 13 +0.0% 1.00x
SuffixCountableRangeLazy 18 18 +0.0% 1.00x
SuffixSequence 3700 3698 -0.1% 1.00x (?)
SuffixSequenceLazy 3653 3663 +0.3% 1.00x (?)
SumUsingReduce 102 101 -1.0% 1.01x
SumUsingReduceInto 97 97 +0.0% 1.00x
SuperChars 20060 20433 +1.9% 0.98x (?)
TwoSum 1475 1476 +0.1% 1.00x (?)
TypeFlood 0 0 +0.0% 1.00x
UTF8Decode 298 297 -0.3% 1.00x
UTF8Decode_InitDecoding 1353 1352 -0.1% 1.00x
UTF8Decode_InitDecoding_ascii 651 661 +1.5% 0.98x (?)
UTF8Decode_InitFromBytes 1173 1181 +0.7% 0.99x (?)
UTF8Decode_InitFromData 1256 1255 -0.1% 1.00x (?)
UTF8Decode_InitFromData_ascii 718 724 +0.8% 0.99x (?)
Walsh 434 435 +0.2% 1.00x (?)
WordCountHistogramASCII 6796 6830 +0.5% 1.00x (?)
WordCountHistogramUTF16 10144 10164 +0.2% 1.00x (?)
WordCountUniqueASCII 2047 2051 +0.2% 1.00x (?)
WordCountUniqueUTF16 4517 4511 -0.1% 1.00x (?)
WordSplitASCII 9885 9979 +1.0% 0.99x (?)
XorLoop 403 403 +0.0% 1.00x
Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

jrose-apple
jrose-apple reviewed Jul 23, 2018
View reviewed changes
stdlib/public/SDK/Foundation/NSArray.swift Outdated
@@ -31,7 +31,7 @@ extension Array : _ObjectiveCBridgeable {
/// The provided `NSArray` will be copied to ensure that the copy can
/// not be mutated by other code.
internal init(_cocoaArray: NSArray) {
_sanityCheck(_isBridgedVerbatimToObjectiveC(Element.self),
precondition(_isBridgedVerbatimToObjectiveC(Element.self),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an expensive upgrade (for most of the Foundation things). assert is probably fine, given that _sanityCheck would have been compiled out in a release build too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's the better call.

@airspeedswift airspeedswift requested a review from eeckstein July 23, 2018 17:31
eeckstein
eeckstein requested changes Jul 23, 2018
View reviewed changes
test/SILOptimizer/specialize_checked_cast_branch.swift
@@ -34,8 +34,6 @@ public func ArchetypeToArchetypeCast<T1, T2>(t1 : T1, t2 : T2) -> T2 {
// CHECK: return [[T0]]
//
// CHECK: bb2
// CHECK: integer_literal $Builtin.Int1, -1
// CHECK: cond_fail
Copy link
Contributor

@eeckstein eeckstein Jul 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the integer_literal+cond_fail with a check for the trap builtin:

// CHECK: builtin "int_trap"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swiftlang swiftlang deleted a comment from swift-ci Jul 24, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jul 24, 2018
@airspeedswift airspeedswift mentioned this pull request Jul 24, 2018
Merged
@airspeedswift
Copy link
Member Author

Test with swiftlang/swift-corelibs-foundation#1640

@swift-ci please test linux platform

@airspeedswift
Copy link
Member Author

@swift-ci please test macOS platform

@airspeedswift
Copy link
Member Author

Test with swiftlang/swift-corelibs-foundation#1640

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d09c2ff

@airspeedswift
Copy link
Member Author

@swift-ci please test macOS platform

1 similar comment
@airspeedswift
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d09c2ff

@airspeedswift
Copy link
Member Author

Test with swiftlang/swift-corelibs-foundation#1640

@swift-ci please test linux platform

@airspeedswift
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 24cc616

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 24cc616

@airspeedswift
Copy link
Member Author

@swift-ci clean test macOS platform

@airspeedswift airspeedswift changed the title [stdlib][WIP] Take several underscored stdlib functions private [stdlib] Take several underscored stdlib functions private Jul 24, 2018
@airspeedswift airspeedswift merged commit 3458794 into swiftlang:master Jul 25, 2018
@airspeedswift airspeedswift deleted the privatization branch August 18, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

@eeckstein eeckstein eeckstein requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@airspeedswift @swift-ci @jrose-apple @eeckstein