[WIP] Serialize local functions inside transparent functions #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
from
e1a26ff to
89125ff
Compare
|
@swift-ci Please test |
| auto Tuple = static_cast<const TupleTypeMetadata *>(type); | ||
| return Tuple->NumElements; | ||
| } | ||
|
|
There was a problem hiding this comment.
Was this reordering intentional?
There was a problem hiding this comment.
Yeah, it is in its own patch. Unless I'm missing something the old ordering was a mistake?
There was a problem hiding this comment.
It feels more natural to put the tuple functions together, after the '// -- Tuple destructuring.' section. Previously swift_TupleMirror_count came first, then some other unrelated functions, then the rest of the TupleMirror stuff.
If you prefer I can drop this patch, it's not related to anything else in the series. Arguably moving code around destroys 'git blame' history, but I have some other changes to this file that are not yet committed, so I decided to fix this nit.
There was a problem hiding this comment.
Nah, it's fine. Just wondering why.
There was a problem hiding this comment.
It's so much harder to make your code look good when the language doesn't enforce bottom-up function order ;)
There was a problem hiding this comment.
Yeah, the generative approach to declarations in ML family languages is so much more elegant than this multi-pass declarative crap
slavapestov
force-pushed
the
serialize-transparent
branch
from
89125ff to
b939500
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
from
b939500 to
24ac970
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
from
24ac970 to
b4ed608
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
from
b4ed608 to
dc29e3c
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
2 times, most recently
from
21a6693 to
38f9841
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
serialize-transparent
branch
from
38f9841 to
ed8974d
Compare
|
@swift-ci Please test |
…il-serialize-all When we're not serializing SIL for all function bodies, @_transparent functions can only reference internal functions that are declared @_versioned, otherwise there's no serialized body and no public entry point, so any client that inlines the @_transparent function will not be able to link. This patch adds the minimum set of @_versioned declarations to allow a non-optimized build of the standard library and overlays. Recall that this attribute is just a temporary hack to make progress on building the standard library with resilience enabled. Once availability and resilience learn about each other, @_versioned will be replaced by having an availability annotation on an internal declaration. Invariants will be diagnosed by Sema instead of asserting in the SIL verifier. Finally, the set of "internal but available" declarations will eventually be audited instead of determined by experimentation. This almost closes out https://bugs.swift.org/browse/SR-267. The remaining issue is an interaction between SIL optimizations and serialization that will be fixed with some upcoming changes to the optimizer.
The original SILFunction may be [fragile] because it came from an imported module, or maybe it was [fragile] because it was declared @_transparent by the user. Furthermore, the devirtualizer can devirtualize calls inside [fragile] functions, pointing them at non-fragile functions. FIXME: For resilience, we cannot devirtualize this stuff anyway. Instead, try to not set [fragile] on clones unless needed.
Let's abuse the [thunk] attribute to mean "serialize the body of this function but only if it is referenced from a [fragile] function."
slavapestov
force-pushed
the
serialize-transparent
branch
from
ed8974d to
daed4b3
Compare
|
@swift-ci Please test |
|
Note to self: |
slavapestov
changed the title
MaxDesiatov
pushed a commit
that referenced
this pull request
Oct 19, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.