Don’t dive into null parts of AST. #18153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@akyrtzi Did you want to look at this? Thanks! |
akyrtzi
reviewed
Jul 23, 2018
lib/AST/USRGeneration.cpp
Outdated
| @@ -226,7 +226,7 @@ bool ide::printDeclUSR(const ValueDecl *D, raw_ostream &OS) { | |||
| return printObjCUSR(D, OS); | |||
| } | |||
|
|
|||
| if (!D->hasInterfaceType()) | |||
| if (!D->hasInterfaceType() || D->getInterfaceType()->is<ErrorType>()) | |||
There was a problem hiding this comment.
This is the reason the test is filing, could you verify whether this change is necessary, is it really fixing a crash in your original test case ?
|
Generally it would be ideal if you could add a regression test but I can understand if it is too difficult to reduce the original failing test case. |
|
@swift-ci please smoke test |
akyrtzi
approved these changes
Jul 24, 2018
|
I agree a regression test would be great. If I can come up with one, I'll do another PR. |
akyrtzi
added a commit
that referenced
this pull request
Jul 27, 2018
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Jul 30, 2018
…uces-no-output Don’t dive into null parts of AST. # Conflicts: # lib/IDE/SourceEntityWalker.cpp
nathawes
pushed a commit
to nathawes/swift
that referenced
this pull request
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling code with certain errors, it is possible to get null pointers in the AST.
The compiler indexes even when there are errors, and the indexing code then tries to walk into the null pointers, causing a crash. As a result, the frontend crashes, and the developer does not get to see the errors. This PR adds a null check for this specific case. It does not solve the general problem.
Resolves rdar://42314665