[ownership] Always print out ownership argument annotations whether o… #18186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r not -enable-sil-ownership is passed in. This is how we originally controlled whether or not we printed out ownership annotations when we printed SIL. Since then, I have changed (a few months ago I believe) the ownership model eliminator to know how to eliminate these annotations from the SIL itself. So this hack can be removed. As an additional benefit, this will let me rename -enable-sil-ownership to -enable-sil-ownership-verifier. This will I hope eliminate confusion around this option in the short term while I am preparing to work on semantic sil again. rdar://42509812
|
@swift-ci smoke test and merge |
|
@atrick finally got around to finishing this. I think it will resolve confusion. |
atrick
reviewed
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r not -enable-sil-ownership is passed in.
This is how we originally controlled whether or not we printed out ownership
annotations when we printed SIL. Since then, I have changed (a few months ago I
believe) the ownership model eliminator to know how to eliminate these
annotations from the SIL itself. So this hack can be removed.
rdar://42509812