Sema: Prefer class properties to protocol properties when ranking overloads #18206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rloads This was the old behavior in Swift 4.1, but it broke after some changes to redeclaration checking and shadowing. Fixes <rdar://problem/42201583>.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@hamishknight Please take a look. |
DougGregor
approved these changes
Jul 25, 2018
huonw
reviewed
Jul 25, 2018
| // If both are properties and one is in a protocol, prefer the one not in | ||
| // a protocol. | ||
| // | ||
| // This is a Swift 4.1 compatibility hack. Changes elsewhere in the compiler |
There was a problem hiding this comment.
Should we conditionalize it on language version?
There was a problem hiding this comment.
Arguably this is in line with preferring concrete implementations over protocol implementations. It is a little funny when the concrete implementation is a superclass, but…
|
Build failed |
|
Build failed |
|
Thanks for addressing this! LGTM as a stopgap until we decide on a consistent rule to follow for all types of members (i.e not just properties) in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the old behavior in Swift 4.1, but it broke after some changes
to redeclaration checking and shadowing.
Fixes rdar://problem/42201583.