Add support for tfc.makeIteratorGetNextWithDatasets from graph operations #18223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
changed the title
bgogul
force-pushed
the
unknown_array_attribute_8331
branch
from
88a6ecb to
a2d859e
Compare
|
@swift-ci please test tensorflow |
bgogul
changed the title
mhong
approved these changes
Jul 26, 2018
| @@ -584,7 +584,11 @@ struct TFGraphLowering : public SILInstructionVisitor<TFGraphLowering, GLStatus> | |||
| /// | |||
| /// FIXME: Dissolve this builtin into a set of finer-grained, composable | |||
| /// features. | |||
| GLStatus visitTFDataset(BuiltinInst *inst); | |||
| template <typename Inst> | |||
There was a problem hiding this comment.
if it can simplify the patch (e.g. remove templating), pls feel free to remove the support for builtin inst, and only support graph_op.
There was a problem hiding this comment.
Let me leave the code as is for now. We can clean it up when strict deabstraction is enabled by default.
rxwei
reviewed
Jul 26, 2018
| // Even when this built-in returns multiple tensors, they are always presented | ||
| // by a single tuple. | ||
| std::vector<TF_DataType> outputTypes; | ||
| for (const SILValue& result : inst->getResults()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to enables strict deabstraction in dataset.swift test.