Skip to content

In swift-project-settings.el, don't outdent case labels. #18229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018
Merged

In swift-project-settings.el, don't outdent case labels. #18229

merged 1 commit into from
Jul 26, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jul 25, 2018

I fixed a couple small annoyances in the emacs C++ syntax support.

@gottesmm @rudkx is anyone still using the checked in swift-project-settings.el? Do people actually apply .dir-locals? Shouldn't this be consistent with clang-format?

@atrick
Copy link
Contributor Author

atrick commented Jul 25, 2018

@swift-ci smoke test.

@gottesmm
Copy link
Contributor

I wish that we were not using .dir-locals in general. Every time the prompt comes up it annoys me slightly. I use clang-format on my c++ code.

@atrick
Copy link
Contributor Author

atrick commented Jul 25, 2018

FWIW, I'm on board with removing .dir-locals. I'm not sure if anyone wants it. At the moment I just want to quickly fix some annoyances though.

@rudkx
Copy link
Contributor

rudkx commented Jul 25, 2018

I haven't been using either. I just try to remember to clang-format everything and tend to use my own settings from my own config files.

@rudkx
Copy link
Contributor

rudkx commented Jul 26, 2018

BTW, @gottesmm, you can do:

;; Don't set or prompt about dir local variables.
(setq enable-dir-local-variables nil)

to avoid the prompts re: dir locals. I added this to my init file a few years back.

@atrick
Copy link
Contributor Author

atrick commented Jul 26, 2018

@rudkx thanks. I'll disable .dir-locals and avoid using swift-project-settings. When the time is right, we can just delete both these files.

@atrick atrick merged commit 90c9c06 into swiftlang:master Jul 26, 2018
@atrick atrick deleted the dir-locals branch July 27, 2018 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants