Skip to content

Remove a too-strict assertion concerning nested protocols #18241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Jul 26, 2018

Follow-up for #18048. This isn't allowed in the language, but the compiler shouldn't crash!

Thanks for catching this, @slavapestov.

This isn't allowed in the language, but the compiler shouldn't crash!
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test


struct OuterForUFI {
@usableFromInline
protocol Inner { // expected-error {{protocol 'Inner' cannot be nested inside another declaration}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me shudders when he sees test case

@jrose-apple jrose-apple merged commit 23df594 into swiftlang:master Jul 26, 2018
@jrose-apple jrose-apple deleted the nest branch July 26, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants