Add libSyntax support for #chainableGradient. #18255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename GradientExpr to ReverseAutoDiffExpr for consistency with the class hierarchy.
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jul 26, 2018
|
@swift-ci please test tensorflow |
3 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
dan-zheng
reviewed
Jul 26, 2018
| traits=['Parenthesized'], | ||
| children=[ | ||
| Child('Identifier', kind='Token', | ||
| token_choices=[ | ||
| 'PoundGradientToken', | ||
| 'ChainableGradientToken', |
There was a problem hiding this comment.
Do you mean PoundChainableGradientToken?
|
@swift-ci please test tensorflow |
|
@swift-ci Please test tensorflow |
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up on #18250, this patch adds libSyntax support and fixes the naming in syntax nodes for reverse-mode differential operators.
Also rename
GradientExprtoReverseAutoDiffExprin syntax nodes, since it is supposed to generalize the C++ classswift::ReverseAutoDiffExprinstead of its subclassswift::GradientExpr.