[4.2][CodeComplete] Use PrintOptionalAsImplicitlyUnwrapped to print IUO #18270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other instances of fb9c65e. Consistently use PrintOption.PrintOptionalAsImplicitlyUnwrapped to print IUO. rdar://problem/41046225 rdar://problem/42443512
|
@swift-ci Please test |
|
@swift-ci Please nominate |
rintaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #18217 reviewed by @rudkx
PrintOptions.PrintOptionalAsImplicitlyUnwrappedto printOptionaltype annotations in code-completion. Previously, it used to manually print!after object type of the optional with an assumption where the type isOptional. Because of various reasons, there are several circumstances that the type is not optional, thus caused SourceKit crashes. Use ASTPrinter with the option which can handle them.