Skip to content

Revert "migrator: handle AppKit protocol migrations. rdar://42480588" #18280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 27, 2018

Reverts #18226

Unfortunately these changes have regressed multiple internal bots - rdar://problem/42652615

@xedin
Copy link
Contributor Author

xedin commented Jul 27, 2018

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jul 27, 2018

/cc @nkcsgexi

@xedin
Copy link
Contributor Author

xedin commented Jul 27, 2018

I'm actually going to force revert it for now because everything is failing not being able to import AppKit on some platforms.

@xedin xedin merged commit c06a789 into master Jul 27, 2018
@xedin
Copy link
Contributor Author

xedin commented Jul 27, 2018

It looks like REQUIRES: objc_interop is not enough here to prevent it from running on anything expect macOS.

@xedin
Copy link
Contributor Author

xedin commented Jul 27, 2018

@nkcsgexi ^

@nkcsgexi
Copy link
Contributor

Thank you for reverting it! @xedin i will take a look later

@shahmishal shahmishal deleted the revert-18226-42480588 branch May 13, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants