[4.2][AST] Fix a crash in UnqualifiedLookup #18306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add null type check for `Self` type in `UnqualifiedLookup`. It seems this doesn't happen in normal compilation. But when code-completion happens in inactive conditional compilation block, since surrounding context hasn't been typechecked, `Self` type can be null. rdar://problem/41234606
|
@swift-ci Please test |
|
@swift-ci nominate |
|
/cc @rintaro |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Add null type check for Self type in UnqualifiedLookup. It seems this doesn't happen in normal compilation. But when code-completion happens in inactive conditional compilation block, since surrounding context hasn't been typechecked, Self type can be null.
Scope: Code-completion regarding completion inside conditional compilation blocks
Issue: rdar://problem/41234606
Risk: Low. This is just a null check to avoid crash for code-completion functionality
Testing: Added regression test case.
Reviewed By: Doug Gregor (#18279)