[AST] Refactor name lookup a bit #18317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
refactor-name-lookup
branch
from
e435774 to
4d5762e
Compare
|
@swift-ci please smoke test and merge |
AnyObject lookup is a completely separate path from normal qualified lookup, so separate it out and pull out the common bits.
The “name lookup into a module” lookup is completely different from performing name lookup into a type. Factor it out into its own utility routine.
Make the core lookupQualified() API accept an array of TypeDecls in which it should look, rather than looking into a Type. This is in preparation for breaking more type-checker dependencies in the name lookup code.
DougGregor
force-pushed
the
refactor-name-lookup
branch
from
4d5762e to
48fb227
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor qualified name lookup into a few different entry points:
AnyObjectlookup (for finding@objcmembers on anAnyObjectinstance)ModuleName.Footo reference something in a module)