[Sema] Better key path failure diagnosis for unresolved roots #18329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregomni
changed the title
|
@gregomni Sorry I'm out for a bit, going to take a look tonight! |
xedin
approved these changes
Jul 29, 2018
test/Constraints/keypath.swift
Outdated
| var here: (() -> Void)? | ||
| } | ||
| let some = Some(keyPath: \Demo.here) | ||
| // expected-error@-1 {{cannot convert value of type 'ReferenceWritableKeyPath<Demo, (() -> Void)?>' to expected argument type 'KeyPath<_, ((_) -> Void)?>'}} |
There was a problem hiding this comment.
Could you please add a FIXME here to improve this diagnostic, it's better in a way that points to a correct place but doesn't really pinpoint the problem unfortunately still...
|
@xedin Sure thing, thanks! |
|
@swift-ci Please smoke test and merge. |
…se the root interface type for diagnosis.
|
@swift-ci Please smoke test. |
|
@swift-ci Please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the root type of a keypath is unresolved by the constraint system, use the root interface type for diagnosis.
Resolves SR-7339.