Replace some uses of getInput(). #18336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archetype tests in the code being removed will never succeed because there is code earlier in the function testing for any archetypes in either type, and that path always returns. The remaining test is broken (it's comparing source input and target input and then target input to target result rather than comparing the source input and target input and then source result and target result), and is just duplicating the test that happens above. If we really want to do a better test for substitutability we can do so at a later time. In the meantime, I don't think it makes sense to leave redundant comparisons and an unreachable return in place.
Use getParams() instead.
rudkx
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use getParams() instead.
Also, remove some code from
classifyDynamicCast()that was both incorrect and is basically dead as a result of code earlier in the function.