Skip to content

[ConstraintSystem] Hold slightly less state in DisjunctionChoice. #18359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2018
Merged

[ConstraintSystem] Hold slightly less state in DisjunctionChoice. #18359

merged 1 commit into from
Jul 31, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jul 30, 2018

We only care about whether the disjunction was created for an explicit
conversion.

@rudkx
[ConstraintSystem] Hold slightly less state in DisjunctionChoice.
7abf4b6 
We only care about whether the disjunction was created for an explicit
conversion.
@rudkx rudkx requested a review from xedin July 30, 2018 21:53
@rudkx
Copy link
Contributor Author

rudkx commented Jul 30, 2018

@swift-ci Please smoke test

xedin
xedin approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rudkx rudkx merged commit 128a7ff into swiftlang:master Jul 31, 2018
@rudkx rudkx deleted the simplify-state-for-disjunction-choice branch July 31, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @xedin