Don't set overrides on imported protocol requirements [5.0] #18376

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:598:34: error: no matching function for call to 'create'
02:53:26   result_loc_info.binding_decl = swift::PatternBindingDecl::create(
02:53:26                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/swift/include/swift/AST/Decl.h:1946:30: note: candidate function not viable: requires 6 arguments, but 7 were provided
02:53:26   static PatternBindingDecl *create(ASTContext &Ctx, SourceLoc StaticLoc,
02:53:26                              ^
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/swift/include/swift/AST/Decl.h:1952:30: note: candidate function not viable: requires 8 arguments, but 7 were provided
02:53:26   static PatternBindingDecl *create(ASTContext &Ctx, SourceLoc StaticLoc,
02:53:26                              ^
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1239:7: error: no matching function for call to 'create'
02:53:26       swift::PatternBindingDecl::create(
02:53:26       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/swift/include/swift/AST/Decl.h:1946:30: note: candidate function not viable: requires 6 arguments, but 7 were provided
02:53:26   static PatternBindingDecl *create(ASTContext &Ctx, SourceLoc StaticLoc,
02:53:26                              ^
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/swift/include/swift/AST/Decl.h:1952:30: note: candidate function not viable: requires 8 arguments, but 7 were provided
02:53:26   static PatternBindingDecl *create(ASTContext &Ctx, SourceLoc StaticLoc,
02:53:26                              ^
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1502:26: error: no member named 'getStorageKind' in 'swift::VarDecl'
02:53:26     if (variable.m_decl->getStorageKind() !=
02:53:26         ~~~~~~~~~~~~~~~  ^
02:53:26 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1503:37: error: no member named 'Computed' in 'swift::AbstractStorageDecl'
02:53:26         swift::AbstractStorageDecl::Computed)
02:53:26         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

Maybe @rjmccall needs to cherry-pick some patches on the lldb side?

rjmccall · 2018-07-31T09:24:23Z

No, 012af55 (reacting to the change to AbstractStorageDecl) is in swift-5.0-branch, as is 906c4bf (reacting to the change to PatternBindingDecl). The build is just using swift-4.2-branch, as you can see from the log:

02:24:18 Updating '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb'
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18 HEAD is now at 001624c Merge pull request #793 from jasonmolenda/r41372699-min-os-version-swift42
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18 No rebase in progress?
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18 Your branch is up-to-date with 'origin/swift-4.2-branch'.
02:24:18 Already on 'swift-4.2-branch'
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18
02:24:18 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.0-branch/lldb
02:24:18 HEAD is now at 001624c Merge pull request #793 from jasonmolenda/r41372699-min-os-version-swift42
02:24:18

001624c is indeed the current head of swift-lldb's swift-4.2-branch.

slavapestov · 2018-07-31T22:00:43Z

@swift-ci Please test

swift-ci · 2018-07-31T22:42:30Z

Build failed
Swift Test Linux Platform
Git Sha - e440e1d

shahmishal · 2018-07-31T23:35:53Z

@swift-ci test

swift-ci · 2018-08-01T00:03:21Z

Build failed
Swift Test OS X Platform
Git Sha - e440e1d

shahmishal · 2018-08-01T00:13:05Z

@fredriss Have you seen this before?

/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-swift-5.0-branch/lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:598:34: error: no matching function for call to 'create'
  result_loc_info.binding_decl = swift::PatternBindingDecl::create(
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

fredriss · 2018-08-01T00:16:00Z

@shahmishal never seen this

fredriss · 2018-08-01T00:48:34Z

There have been no modification involving PatternBindingDecl::create in LLDB since 2015...

swift-ci · 2018-08-01T00:57:13Z

Build failed
Swift Test OS X Platform
Git Sha - e440e1d

rjmccall · 2018-08-01T01:04:41Z

No, see my comment above. A patch to that code was committed on July 6th as apple/swift-lldb@906c4bf, and it should be in swift-5.0-branch.

fredriss · 2018-08-01T01:09:49Z

Are you talking about 906c4bf? because according to 'git branch --contains' it is on swift-5.0-branch. But this patch doesn't touch the line where the error is reported

fredriss · 2018-08-01T01:12:21Z

Doh, it touches exactly this piece of code, sorry. The commit is on swift-5.0-branch

fredriss · 2018-08-01T01:17:17Z

Sorry, I'm reacting to Mishal's message, but I should have read the history of the PR. John analysis is exactly correct, this build has checked out the swift-4.2-branch in LLDB.

slavapestov · 2018-08-01T03:42:48Z

@swift-ci Please test macOS

swift-ci · 2018-08-01T04:58:38Z

Build failed
Swift Test OS X Platform
Git Sha - e440e1d

shahmishal · 2018-08-01T17:30:10Z

@swift-ci Please test macOS

slavapestov added 2 commits July 30, 2018 17:42

ClangImporter: Set the 'is dynamic' bit explicitly on synthesized dec…

faf31d8

…larations

ClangImporter: Only set overrides on class members

e440e1d

Fixes <rdar://problem/42635132>.

rjmccall mentioned this pull request Aug 1, 2018

[5.0] Recursive metadata fixes omnibus #18383

Merged

slavapestov merged commit e9465a6 into swiftlang:swift-5.0-branch Aug 1, 2018

Don't set overrides on imported protocol requirements [5.0] #18376

Don't set overrides on imported protocol requirements [5.0] #18376

Uh oh!

Conversation

slavapestov commented Jul 31, 2018

Uh oh!

slavapestov commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

shahmishal commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

shahmishal commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

shahmishal commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

slavapestov commented Jul 31, 2018

Uh oh!

rjmccall commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slavapestov commented Jul 31, 2018

Uh oh!

swift-ci commented Jul 31, 2018

Uh oh!

shahmishal commented Jul 31, 2018

Uh oh!

swift-ci commented Aug 1, 2018

Uh oh!

shahmishal commented Aug 1, 2018

Uh oh!

fredriss commented Aug 1, 2018

Uh oh!

fredriss commented Aug 1, 2018

Uh oh!

swift-ci commented Aug 1, 2018

Uh oh!

rjmccall commented Aug 1, 2018

Uh oh!

fredriss commented Aug 1, 2018

Uh oh!

fredriss commented Aug 1, 2018

Uh oh!

fredriss commented Aug 1, 2018

Uh oh!

slavapestov commented Aug 1, 2018

Uh oh!

swift-ci commented Aug 1, 2018

Uh oh!

shahmishal commented Aug 1, 2018

Uh oh!

Uh oh!

rjmccall commented Jul 31, 2018 •

edited

Loading